----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50452/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh, nabarun nag, and xiaojian zhou. Repository: geode Description ------- The queue manager was closing connections without sending the CloseConnectionOp to the server. Changing the code to call close instead of destroy and passing the keepAlive flag along with the close. Also, changing the cache to set keepAlive *before* marking the cache as closed. This should prevent any races where cache closure triggers the cache client updater to destroy connections or close them with the wrong keepAlive setting while the cache is being closed. Diffs ----- geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java 8c04525e6784d354e12bdf009e8f4e9e6f63fbfa geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java 3844dbbcf758eab4b85ce9d91824076ec267cfcc geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueConnectionImpl.java 40cf58b4093282dd15842e672dbd158638b24f9e geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java 3065691713e02f645e60608a555f78efd40a6872 geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 84ba926ee35638c4263a0d93a8be3fef1e2c5f7f geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java ef23d00c6b65b8d6ea14cf733427cbb67df5fe3f geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java 79f922af383953392425d13f9ea3119ceda0eee7 Diff: https://reviews.apache.org/r/50452/diff/ Testing ------- Thanks, Dan Smith
