> On July 26, 2016, 4:06 p.m., Ken Howe wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java, > > lines 1605-1606 > > <https://reviews.apache.org/r/50468/diff/1/?file=1454329#file1454329line1605> > > > > Javadoc comment doesn't list all of the method's parameters
This was a preexisting condition; the old code did not document its parameters. So I am not going to fix that for this fix. I'll just add javadocs on the new one I am adding. - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50468/#review143633 ----------------------------------------------------------- On July 26, 2016, 3:11 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50468/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 3:11 p.m.) > > > Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai > Boorlagadda. > > > Bugs: GEODE-1700 > https://issues.apache.org/jira/browse/GEODE-1700 > > > Repository: geode > > > Description > ------- > > A common method is now used for writing async ops to disk. > The same method is now used for both flushing an item that > has been taken out of the queue and for when the queue is > full causing a sync write to be done. > > Also did a minor refactoring to get rid of the "removed" flag. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > 698e3bd101ccec92833a1feead0a253ae8ce9bf0 > > Diff: https://reviews.apache.org/r/50468/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
