----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50587/#review144129 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java (line 425) <https://reviews.apache.org/r/50587/#comment210136> This "if" needs braces geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java (line 1604) <https://reviews.apache.org/r/50587/#comment210137> remove this TODO geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java (line 3722) <https://reviews.apache.org/r/50587/#comment210139> I wish this code wasn't duplicated in AbstractRegionMap. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/LockObject.java (line 23) <https://reviews.apache.org/r/50587/#comment210142> Since this is never decremented it could be a boolean instead of an int. It looks like you started coding this & thought you would decrement the variable but then decided you didn't need to. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java (line 341) <https://reviews.apache.org/r/50587/#comment210150> I know you're just merging stuff that other people did but this code really should be in serializeAndAddPart instead of addObjPart. geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java (line 190) <https://reviews.apache.org/r/50587/#comment210151> Remove customer name from this comment. I think they were all changed to "performance" geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java (line 191) <https://reviews.apache.org/r/50587/#comment210155> We should change this to limit it to 16-bit integers. I don't see any uses of it that would cause memory bloat in the current code base but that could change in the future. - Bruce Schuchardt On July 28, 2016, 11:43 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50587/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 11:43 p.m.) > > > Review request for geode, Barry Oglesby, Bruce Schuchardt, Jason Huynh, and > Jacob Barrett. > > > Repository: geode > > > Description > ------- > > This includes merge from 82. Please check your chengaes with 82 > > > jason 79be29188b440e217cda50e41af853f882dd9193 > jason 49e6458fcc2aa294fc5dfd41ba47bddc92f29dfe > jason 30ba06dbc5ee06dab7b0ff7b7275619612b7a868 > jacob 1544bda2c722bddf94db6f2e807b302f9b5df303 > Jacob 97cd29a821b770a54412c4abf20f5df0398e9405 > barry 37a942b9ab33e301f3bd41270a63ad0433f184bd > barry 3210ed80258a6518f8b92ae9adfd96e18db1f218 > barry 486a653d037ed3f13c7061abe887d6ab306261d4 > barry 35a6c8b6236ef329fe5ace121c657b529725ec32 > barry 09f9b953b07b26bc3a19cc00c22f8ed047f6f6cf > barry 49fc39dc7224fe42f73b6363de66b6f8f6ed7be6 > Amogh changes 18dd055dc75f94c460fba81d7dfdc2617fafb0a5 > b3322a097cdf0d9ecaf94c600b61c7d62d772cea > > Other improvement:We take lock on key while doing op on BucketRegion. > In that case wenotify to other thread only when there is thread waiting for > it. > Modified condition to log message. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/AbstractRegionMap.java > f3cb3d6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java > abe38b6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/DistributedCacheOperation.java > f51717d > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/FilterRoutingInfo.java > 7f5b587 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerMap.java > 084140f > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerRegion.java > eeefaee > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HAContainerWrapper.java > b0f3e45 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueue.java > 85b50a1 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/LockObject.java > 612b71a > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java > d351569 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/ClientUpdateMessageImpl.java > 0fb915e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java > 459cf5f6 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java > 1c3819e > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java > 8b6a700 > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java > ccdf42a > > geode-cq/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqServiceImpl.java > e1e158c > > geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfDUnitTest.java > ef9e61b > > geode-cq/src/test/java/com/gemstone/gemfire/cache/query/cq/dunit/CqPerfUsingPoolDUnitTest.java > dcd3915 > > Diff: https://reviews.apache.org/r/50587/diff/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
