Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/224#discussion_r73213204
  
    --- Diff: 
geode-core/src/main/java/com/gemstone/gemfire/management/internal/ManagementAgent.java
 ---
    @@ -509,8 +510,7 @@ private void registerAccessControlMBean() {
     
     
       private boolean isIntegratedSecurity() {
    --- End diff --
    
    We can get rid of this method. I believe this is called to check if we need 
to enabled pulse security in the same file as well. Yeah, what about pulse 
security? Do we need to add another enum or just say if jmx is enabled. pulse 
should be enabled as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to