----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50903/ -----------------------------------------------------------
(Updated Aug. 10, 2016, 8:39 p.m.) Review request for geode and anilkumar gingade. Changes ------- Based on Anils feedback, I updated the changes to only close the connection if a cache client updater exits. If an endpoint crashes, we will still call destroyConnection. Repository: geode Description ------- The queue manager was closing connections without sending the CloseConnectionOp to the server. Changing the code to call close instead of destroy and passing the keepAlive flag along with the close. Also, changing the cache to set keepAlive *before* marking the cache as closed. This should prevent any races where cache closure triggers the cache client updater to destroy connections or close them with the wrong keepAlive setting while the cache is being closed. Note that I changed the default value for keepAlive in the cache and the pool to be true. I did this because the DurableClientNetDown test forces the connections to be closed without closing the cache, so it uses the default value, but also because I think this is probably safer for cases of abnormal termination that connections are closed by default with keepAlive=true until the cache is actually closing. Diffs (updated) ----- geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/InternalPool.java fcb0ae8358a1ec2394bf74bd7929867dd5e6f77e geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PoolImpl.java 65a4dd13c25f5363f4d5a6bc2d4da1f7806596a0 geode-core/src/main/java/com/gemstone/gemfire/cache/client/internal/QueueManagerImpl.java 7c9b187c6bc7ed6db64ac5670eb1daa3c594372f geode-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 05bc83837032c95114da118e197c01ca2b3cd4f4 geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/AutoConnectionSourceImplJUnitTest.java 8deedc18491c6308cc1628e006098ec22640fe5d geode-core/src/test/java/com/gemstone/gemfire/cache/client/internal/QueueManagerJUnitTest.java c2872e798cec373b6fba4a07a3ce8608cf235c37 Diff: https://reviews.apache.org/r/50903/diff/ Testing ------- Thanks, Dan Smith
