----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50962/#review145401 -----------------------------------------------------------
Ship it! Ship It! - anilkumar gingade On Aug. 10, 2016, 6:13 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50962/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2016, 6:13 p.m.) > > > Review request for geode and anilkumar gingade. > > > Repository: geode > > > Description > ------- > > Extracted CQAttributesImpl to it's own class, and fixed the > synchronization of cqListeners so that we grab a snapshot of the > listeners to check to avoid races where the listeners can change after > we check for null. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/CqAttributesFactory.java > 101c9e66be031be1b375150feaf410a025fd3efa > > geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImpl.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/cq/CqAttributesImplJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50962/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
