----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51125/#review145879 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Aug. 15, 2016, 6:56 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51125/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 6:56 p.m.) > > > Review request for geode, Anthony Baker, Darrel Schneider, Kevin Duling, Lynn > Hughes-Godfrey, Lynn Gallinat, and Dan Smith. > > > Bugs: GEODE-1782 > https://issues.apache.org/jira/browse/GEODE-1782 > > > Repository: geode > > > Description > ------- > > GEODE-1782: stat resources with different time stamps should not be equal > > * StatArchiveWithConsecutiveResourceInstGenerator generates gfs with multiple > stat resources of same name but different times > * StatArchiveWithConsecutiveResourceInstIntegrationTest confirms existence of > bug GEODE-1782: StatArchiveReader ignores later stats reso > urce with same name as closed stats resource > * ResourceInstTest verifies the underlying issue in > StatArchiveReader.ResourceInst.equals and the fix > > Note: this changeset builds upon the changeset for GEODE-1781 (same branch): > https://reviews.apache.org/r/51098 > > Explanation of new tests: I started out with a very large .gfs file and > reproduced the bug with > StatArchiveWithConsecutiveResourceInstIntegrationTest. Darrel helped identify > the underlying cause in StatArchiveReader.ResourceInst.equals. I then wrote > the unit test ResourceInstTest to reproduce the bug at the lowest level > possible and fix it. Next I created > StatArchiveWithConsecutiveResourceInstGenerator to generate a tiny .gfs file > for StatArchiveWithConsecutiveResourceInstIntegrationTest so that I could > check it in as well since it verifies the bug and the fix at a higher level. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/statistics/StatArchiveReader.java > 12637bc > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/ResourceInstTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGenerator.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstGeneratorTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/com/gemstone/gemfire/internal/statistics/StatUtils.java > PRE-CREATION > > geode-core/src/test/resources/com/gemstone/gemfire/internal/statistics/StatArchiveWithConsecutiveResourceInstIntegrationTest.gfs > PRE-CREATION > > Diff: https://reviews.apache.org/r/51125/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >
