----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51186/ -----------------------------------------------------------
Review request for geode and Barry Oglesby. Repository: geode Description ------- Extending FunctionServiceBase with tests that use a client server topology. Added tests of onRegion with PRs as well as onServers. Adding tests of P2P onRegion with multiple members and PRs. Adding a temporary workaround for GEODE-1762 to let the function service tests pass even if a Execution.execute throws an exception. This lets us at least run the same tests against these different topologies even though they are throwing different exceptions. Added a test that result collectors receive partial results even after a failure. Diffs ----- geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceBase.java eeb7d8d973434bf89a9984e35f83f42d71a31df7 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientAccessorPRBase.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientAccessorPRDUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientAccessorPRMultipleMembersDUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientAccessorPRMultipleMembersMultihopDUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientBase.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientMultipleOnServerDUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientOnServerBase.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServiceClientOnServerDUnitTest.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorPRBase.java PRE-CREATION geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorPRDUnitTest.java e5bf2d2e6d7069bcf7651d35ed08d0379198cc3c geode-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/FunctionServicePeerAccessorPRMultipleMembersDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/51186/diff/ Testing ------- Thanks, Dan Smith
