----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51465/#review147025 -----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java (line 713) <https://reviews.apache.org/r/51465/#comment214001> This is overkill for this test. Your grand-parent (JUnit4CacheTestCache) closes the cache on each jvm. I think you only need to close them early when you have an async thread stuck. geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java (line 753) <https://reviews.apache.org/r/51465/#comment213999> I think in general it would be better to have the closeCache and async0.join in a finally block after you have done the assertEquals. Also make clear that you expect async0 to block until closeCache is called. geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java (line 914) <https://reviews.apache.org/r/51465/#comment214002> Another way to unstick these async0 guys that are waiting for vm1 to do something (like create all its regions) would be to have the test create those regions and confirm that we stop logging warnings in vm1 and that vm0 completes region creation. - Darrel Schneider On Aug. 26, 2016, 1:36 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51465/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 1:36 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1128: Cleaned up some of the colocation logging tests > > Ensure that the asyncInvocation threads terminate. Failure of a thread to > terminate on one of the tests is apparently responsible for at least 1 CI > failure. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java > b701b70f94f0a8410ea71dd7fb77f586ba456f3f > > Diff: https://reviews.apache.org/r/51465/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Ken Howe > >
