----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52126/#review149861 -----------------------------------------------------------
Ship it! Ship It! - Barry Oglesby On Sept. 21, 2016, 5:40 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52126/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 5:40 p.m.) > > > Review request for geode and Barry Oglesby. > > > Repository: geode > > > Description > ------- > > Don't hold a lock while distributing instantiators. This prevents the > deadlock incoming registrations won't wait wait for registrations that > are being distributed. > > This change might cause instantiators to be registered distributed in a > different order that they were registered in, but that shouldn't cause > any issues. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/InternalInstantiator.java > 03987872308cb6a496770106029be08fdb346c71 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java > 79648e19fdd07a165e6e118c9fbd0a209f470fe7 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java > 2e796e71ef4811212a320240b98f35d9639b7e4e > > Diff: https://reviews.apache.org/r/52126/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
