-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52271/#review151544
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java
 (line 267)
<https://reviews.apache.org/r/52271/#comment219985>

    you may want to put break statement here..As we aleady got exception


- Hitesh Khamesra


On Oct. 5, 2016, 12:36 a.m., Udo Kohlmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52271/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2016, 12:36 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Bruce Schuchardt, and Hitesh 
> Khamesra.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> When reading a GemFire/Geode snapshot from a client the ClientTypeRegistry 
> will fail due code that never allowed for a success case. Even if the type 
> registry was successfull the client would "fail" due to incorrect failure 
> logic.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/org/apache/geode/pdx/internal/ClientTypeRegistration.java
>  8957e7f 
> 
> Diff: https://reviews.apache.org/r/52271/diff/
> 
> 
> Testing
> -------
> 
> precheckin - Done
> regression - snapshot/snapshot.bt - Done
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>

Reply via email to