Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/254#discussion_r82068710
--- Diff:
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/PulseAbstractTest.java
---
@@ -136,6 +146,29 @@
private static final DecimalFormat df2 = new
DecimalFormat(PulseConstants.DECIMAL_FORMAT_PATTERN);
+ @Rule
+ public TestRule testWatcher = new TestWatcher() {
+ @Override
+ public void failed(Throwable t, Description test) {
+ takeScreenshot(test.getDisplayName());
+ }
+ };
+
+ @Rule
+ public RetryRule retryRule = new RetryRule(5);
+
+ public void takeScreenshot(String screenshotName) {
--- End diff --
I found screenshots to be helpful when I was debugging the tests that
failed from switching to phantomjs. Maybe we could keep this code around but
just keep the screenshot testWatcher off by default so that people can turn
them on if desired?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
