So, what form should the JIRA ticket assume? (a) Move HIbernate from develop to a feature branch, or (b) Merge Hibernate code to develop (as a future task, cf GEODE-1416 for how the NC was handled)
After somebody (which I can do, if you like) creates a ticket for the code, I'll create a subtask for moving the accompanying docs. On Thu, Oct 6, 2016 at 9:34 AM, Joey McAllister <jmcallis...@pivotal.io> wrote: > +1 for moving to a feature branch. > > On Thu, Oct 6, 2016 at 9:32 AM Mark Bretl <asf.mbr...@gmail.com> wrote: > > > +1 for feature branch as well. > > > > --Mark > > > > On Thu, Oct 6, 2016 at 9:30 AM, Dan Smith <dsm...@pivotal.io> wrote: > > > > > +1 for moving it to a feature branch. > > > > > > -Dan > > > > > > On Wed, Oct 5, 2016 at 2:40 PM, Jason Huynh <jhu...@pivotal.io> wrote: > > > > Bumping to see if we have come to a decision on whether we want to > move > > > > this to a feature branch and get rid of it for 1.0 or post 1.0, > > > especially > > > > now that the 1.0 release branch has been cut > > > > > > > > On Fri, Sep 23, 2016 at 5:22 PM Anthony Baker <aba...@pivotal.io> > > wrote: > > > > > > > > Likewise! Geode provides an L2 cache for Hibernate. That is, an > > > > application that is using Hibernate could plug in Geode for caching. > > > > Specifically, we implement Hibernate’s cache interfaces like > > > CacheProvider, > > > > RegionFactory, etc. > > > > > > > > There are build-time dependencies on several hibernate jars > > > > (hibernate-annotations, hibernate-core, > hibernate-commons-annotations). > > > No > > > > hibernate source code or jars are shipped with any release. > > > > > > > > Docs: > > > > http://geode.docs.pivotal.io/docs/tools_modules/hibernate_ > > > cache/chapter_overview.html > > > > > > > > Code: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-geode. > > > git;a=tree;f=extensions/geode-modules-hibernate;h= > > > be8b9355934f824b9d4565ec6bfaa5d17a117f45;hb=HEAD > > > > > > > > ~/working/apache-geode-1.0.0-incubating.M3$ unzip -l > > > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip > > > > Archive: > > > > tools/Modules/Apache_Geode_Modules-1.0.0-incubating.M3-Hibernate.zip > > > > Length Date Time Name > > > > -------- ---- ---- ---- > > > > 0 08-01-16 17:01 lib/ > > > > 114497 08-01-16 16:58 lib/geode-modules-1.0.0- > incubating.M3.jar > > > > 56960 08-01-16 17:01 > > > > lib/geode-modules-hibernate-1.0.0-incubating.M3.jar > > > > -------- ------- > > > > 171457 3 files > > > > > > > > ~/working/apache-geode-1.0.0-incubating.M3$ jar tvf > > > > lib/geode-modules-hibernate-1.0.0-incubating.M3.jar > > > > 0 Mon Aug 01 17:01:40 PDT 2016 META-INF/ > > > > 139 Mon Aug 01 17:01:40 PDT 2016 META-INF/MANIFEST.MF > > > > 28210 Mon Jul 25 21:52:24 PDT 2016 META-INF/LICENSE > > > > 584 Fri Jul 08 12:51:12 PDT 2016 META-INF/NOTICE > > > > 0 Mon Aug 01 17:01:40 PDT 2016 com/ > > > > 0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/ > > > > 0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/ > > > > 0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/ > > > > 0 Mon Aug 01 17:01:40 PDT 2016 com/gemstone/gemfire/modules/ > > > hibernate/ > > > > 1210 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/EnumType.class > > > > 5707 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/GemFireCache.class > > > > 1700 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/GemFireCacheListener.class > > > > 7084 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/GemFireCacheProvider.class > > > > 1104 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/ > GemFireQueryCacheFactory.class > > > > 9529 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/GemFireRegionFactory.class > > > > 0 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > > 1020 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/Access$1.class > > > > 9535 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/Access.class > > > > 343 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > ClientServerRegionFactoryDelegate$1.class > > > > 1508 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > ClientServerRegionFactoryDelegate$LocatorHolder.class > > > > 9639 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > ClientServerRegionFactoryDelegate.class > > > > 9739 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > CollectionAccess.class > > > > 2409 Mon Aug 01 17:01:40 PDT 2016 > > > > > > com/gemstone/gemfire/modules/hibernate/internal/EntityRegionWriter.class > > > > 240 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/EntityVersion.class > > > > 964 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > EntityVersionImpl.class > > > > 2446 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/EntityWrapper.class > > > > 5001 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > GemFireBaseRegion.class > > > > 2563 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > GemFireCollectionRegion.class > > > > 7702 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > GemFireEntityRegion.class > > > > 3058 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > GemFireQueryResultsRegion.class > > > > 2547 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/KeyWrapper.class > > > > 2911 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > NonStrictReadWriteAccess.class > > > > 1670 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ReadOnlyAccess.class > > > > 1121 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > ReadWriteAccess.class > > > > 7073 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > RegionFactoryDelegate.class > > > > 581 Mon Aug 01 17:01:40 PDT 2016 > > > > com/gemstone/gemfire/modules/hibernate/internal/ > > > TransactionalAccess.class > > > > > > > > > > > > Anthony > > > > > > > >> On Sep 23, 2016, at 4:54 PM, Roman Shaposhnik <ro...@shaposhnik.org > > > > > > wrote: > > > >> > > > >> You've mentioned my trigger word ;-) Hibernate is licensed under > LGPL > > > >> so could you please specify how is Geode using it? > > > >> > > > >> Thanks, > > > >> Roman. > > > >> > > > >> On Thu, Sep 22, 2016 at 3:15 PM, William Markito < > mark...@apache.org> > > > > wrote: > > > >>> Folks, > > > >>> > > > >>> We're still building the Hibernate cache module [1] but it's > > compatible > > > >>> only with a very old version (3.5) and given that the API has > > > completely > > > >>> changed and unless someone in the community wants to help getting > > this > > > >>> module up-to-date with at least Hibernate 5.x I'd like propose to > > > remove > > > >>> the module from 1.0 / develop until we can work on updating that > > > module. > > > >>> > > > >>> Given that it's already a separate module it shouldn't be that hard > > to > > > be > > > >>> removed. > > > >>> > > > >>> Thoughts ? > > > >>> > > > >>> [1] > > > >>> > > > > http://geode.docs.pivotal.io/docs/tools_modules/hibernate_ > > > cache/chapter_overview.html > > > > > >