----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52655/#review152011 -----------------------------------------------------------
Ship it! Add license headers (already done I think?) and then Ship It! - Kirk Lund On Oct. 10, 2016, 3:14 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52655/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 3:14 p.m.) > > > Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * Add a SimpleSecurityManager > * Add more tests to cover GMSAuthenticator for cached and cacheless locator > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/security/templates/SimpleSecurityManager.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorWithCachelessLocatorDUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/security/templates/SimpleSecurityManagerTest.java > PRE-CREATION > geode-cq/src/test/java/org/apache/geode/security/CQClientAuthDunitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52655/diff/ > > > Testing > ------- > > > Thanks, > > Jinmei Liao > >
