----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52700/#review152061 -----------------------------------------------------------
Fix it, then Ship it! Review use of import formatters (probably need to import etc/eclipseOrganizeImports.importorder) and then Ship It! geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java (line 19) <https://reviews.apache.org/r/52700/#comment220770> Reload formatters to make sure you're using the same import options as the rest of us. The committed formatters are granular to class name only. Which means import static is class.*: import static org.apache.geode.distributed.ConfigurationProperties.*; Non static imports are also granular to class name (that part is correct): import java.util.Collection; import java.util.Iterator; import java.util.Properties; Eclipse has a 2nd formatter file specific to imports, while IntelliJ has a single formatter file: eclipseFormatterProfile.xml eclipseOrganizeImports.importorder intellijIdeaCodeStyle.xml - Kirk Lund On Oct. 10, 2016, 6:54 p.m., Anthony Baker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52700/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 6:54 p.m.) > > > Review request for geode, Kirk Lund and Dan Smith. > > > Repository: geode > > > Description > ------- > > Add more tests to flaky category based on recent CI failures > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/FunctionServiceBase.java > 5cd132781525210ff2869395978f15f2ec853c3d > > geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug48571DUnitTest.java > 4bc7ecb7d1b97b80deb5e0ba549f1108946e34ea > > geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/HAInterestPart2DUnitTest.java > 3fb15b5f5b387710076d512a060d2370bfe2319c > > geode-core/src/test/java/org/apache/geode/management/ClientHealthStatsDUnitTest.java > a62bb06863965a735e34b34ca4e94790657ee548 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java > 3a6a31a69b673438bf88e8933bd7be74b03d2cee > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/SharedConfigurationUsingDirDUnitTest.java > 0683965fa9f38db59230532022fe0bbd7df3513c > > geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java > 395d73e58fb984111c9d441a0ff57a1e1e900ea7 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderDUnitTest.java > 3451b51a16ec8a100d6e27096979dadf60cb5ed2 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentWANPropagation_1_DUnitTest.java > e2461392e2b2e2d57b7d4fd78de19ca3de9abc38 > > Diff: https://reviews.apache.org/r/52700/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Baker > >
