----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52725/ -----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Hitesh Khamesra. Repository: geode Description ------- Amended the logic in the ClientMetadataService to more reliably increment the nonSingleHopsCount. This is done rather than amended each data Op that were to use it. Seems to have vast amounts of formatting changes. Code that has changed: ClientMetadataService : scheduleGetPRMetaData. line 455 and 537 GemFireCacheImpl : getClientMetadataService. line 1970 moved the return clientMetadataService to outside the sync block SingleHopStatsDUnitTest: line 370 removed redundant logic. if/else code blocks exact same implementation Diffs ----- geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java c863d46 geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java d166397 geode-core/src/test/java/org/apache/geode/internal/cache/SingleHopStatsDUnitTest.java a7c7b48 Diff: https://reviews.apache.org/r/52725/diff/ Testing ------- Pre-checkin started Thanks, Udo Kohlmeyer