----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53071/#review153460 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java (line 439) <https://reviews.apache.org/r/53071/#comment222779> I think this test would be a bit clearer if you get rid of the boolean gotExpectedTransactionDataNotColocatedException and instead just add a fail("expected TransactionDataNotColocatedException"); before the catch. I think an even better way exists of doing this that gets rid of the try/catch. One or more of the unit test frameworks has ExpectedException support but I don't remember exactly how it works. But that would be preferred if you can find an example of how to use it. - Darrel Schneider On Oct. 20, 2016, 10:39 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53071/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 10:39 a.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Bugs: GEODE-2021 > https://issues.apache.org/jira/browse/GEODE-2021 > > > Repository: geode > > > Description > ------- > > Throw TransactionDataNotColocatedException when get locally failed with > BucketNotFoundException > Added a dunit test which passes with the fix and failed without the fix. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java > baab79f > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRColocationDUnitTest.java > 1b8d2d1 > > geode-core/src/test/java/org/apache/geode/internal/cache/execute/PRTransactionDUnitTest.java > 516c240 > > Diff: https://reviews.apache.org/r/53071/diff/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >