-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53094/#review153596
-----------------------------------------------------------




geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java (line 
8660)
<https://reviews.apache.org/r/53094/#comment223003>

    It would be better to remove these calls instead of just commenting them 
out.


- Darrel Schneider


On Oct. 21, 2016, 11:41 a.m., Hitesh Khamesra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53094/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2016, 11:41 a.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Darrel Schneider, and Udo 
> Kohlmeyer.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> ExpirationManager tracks the regionEntry as reference to expiryTask. It 
> assumes, it is unique for that key. But consistency check mechanism keeps 
> that regionEntry around and that enforces re-use of that for new update. That 
> introduces the race condition between expiry thread and user thread, it endup 
> not scheduling the entry for expiration. As a fix, now "consistency check 
> mechanism" unschedules the expiry task to avoid this race condition.
> 
> 
> Diffs
> -----
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java
>  e02c7e1 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/EntryEventImpl.java 
> d059aab 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/EntryExpiryTask.java 
> 0c20d32 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> ac4c705 
> 
> Diff: https://reviews.apache.org/r/53094/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hitesh Khamesra
> 
>

Reply via email to