> On Oct. 24, 2016, 5:56 p.m., Karen Miller wrote: > > Ship It!
Nice addition to the documentation. I also verified that the rat check passes. Note that this patch will merge nicely into the develop branch, but will both be incorrect and cause a conflict in short order when the new paths to the documentation (hosted within Apache) get merged into the develop branch. We can fix those issues when they occur. - Karen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53107/#review153714 ----------------------------------------------------------- On Oct. 21, 2016, 10:56 p.m., Dave Barnes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53107/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 10:56 p.m.) > > > Review request for geode, Joey McAllister and Karen Miller. > > > Repository: geode > > > Description > ------- > > GEODE-2023: Add Lucene documentation > > > Diffs > ----- > > geode-book/master_middleman/source/subnavs/geode-subnav.erb > 2373f4b397952372a61923c5b57ef8f6d2102ee3 > geode-docs/tools_modules/book_intro.html.md.erb > 852e3c9de6eba2f83f0c513912c53b771889509e > geode-docs/tools_modules/lucene_integration.html.md.erb PRE-CREATION > > Diff: https://reviews.apache.org/r/53107/diff/ > > > Testing > ------- > > > Thanks, > > Dave Barnes > >
