The lineEndings setting works great. I've pushed the change to develop On Mon, Oct 24, 2016 at 3:47 PM, Dan Smith <dsm...@pivotal.io> wrote:
> I think we have a fix for the spotless line ending issue on windows; Bruce > will check it in shortly: > > diff --git a/build.gradle b/build.gradle > index a734e05..6e82433 100755 > --- a/build.gradle > +++ b/build.gradle > @@ -88,6 +88,7 @@ subprojects { > > apply plugin: "com.diffplug.gradle.spotless" > spotless { > + lineEndings = 'unix'; > java { > eclipseFormatFile > "${rootProject.projectDir}/etc/eclipse-java-google-style.xml" > > > On Mon, Oct 24, 2016 at 2:50 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > > Running geode-core:spotlessCheck complains that all of the .java files > > have format violations > > > > * What went wrong: > > Execution failed for task ':geode-core:spotlessJavaCheck'. > > > Format violations were found. Run 'gradlew spotlessApply' to fix them. > > geode-core\src\jca\java\org\apache\geode\internal\ra\GFConne > > ctionFactoryImpl.java > > geode-core\src\jca\java\org\apache\geode\internal\ra\ > GFConnectionImpl.java > > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA > > LocalTransaction.java > > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA > > ManagedConnection.java > > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA > > ManagedConnectionFactory.java > > geode-core\src\jca\java\org\apache\geode\internal\ra\spi\JCA > > ManagedConnectionnMetaData.java > > etc. > > > > Until this is fixed I can't validate that the changes I check in conform > > to the formatting rules. > > >