----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53154/#review153756 -----------------------------------------------------------
Ship it! Code looks good. Seems like 30 seconds is one of those things that should normally happen very fast, but occasionally might be hung up for some reason (i.e. GC), so why not wait 200 or something. A longer wait max would not slow the test down, but might miss an occasional GC pause or something. - Scott Jewell On Oct. 24, 2016, 11:19 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53154/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 11:19 p.m.) > > > Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken > Howe. > > > Bugs: GEODE-2026 > https://issues.apache.org/jira/browse/GEODE-2026 > > > Repository: geode > > > Description > ------- > > The test was initializing a value to a String, > then starting an async thread that would keep > changing it to an int, > it slept for 100ms and then assummed that the async > thread had changed the value to an Integer. > In rare cases the thread never was able to to its first > put so the value was still a String. > > The test now waits for the async thread to change the value > to an Integer instead of doing a 100ms sleep. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > 5ca3d014b4bac01e239561301666fae5fb0d61ea > > Diff: https://reviews.apache.org/r/53154/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
