----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53108/#review153908 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java (line 279) <https://reviews.apache.org/r/53108/#comment223420> I would not check this change in. - Darrel Schneider On Oct. 21, 2016, 4:43 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53108/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2016, 4:43 p.m.) > > > Review request for geode, Anthony Baker, Darrel Schneider, Jinmei Liao, Kevin > Duling, Swapnil Bawaskar, and Dan Smith. > > > Bugs: GEODE-2012 > https://issues.apache.org/jira/browse/GEODE-2012 > > > Repository: geode > > > Description > ------- > > GEODE-2012: always write stat types to archive > > Note: there are other minor commits on feature/GEODE-2012 that should be > rebased into one commit before committing to develop. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/NanoTimer.java > e8c11456353f0ddb7718cb07da146fa75492995f > > geode-core/src/main/java/org/apache/geode/internal/i18n/LocalizedStrings.java > 8bfdd686eb50605e12cb59015d5ddab99714c563 > > geode-core/src/main/java/org/apache/geode/internal/statistics/HostStatSampler.java > 020b5ab8530783f2c76279f8d130f84496013e3a > > geode-core/src/main/java/org/apache/geode/internal/statistics/SampleCollector.java > 68430a1d830d9f560fb7131d2c567edc6337b7cb > > geode-core/src/main/java/org/apache/geode/internal/statistics/SimpleStatSampler.java > 50f49a70152d45726090d9e3b63ef3daef6008e5 > > geode-core/src/main/java/org/apache/geode/internal/statistics/StatArchiveWriter.java > b8f44e2d50715c5f28132246465cc567c4702946 > > geode-core/src/main/java/org/apache/geode/internal/util/concurrent/StoppableCountDownLatch.java > 1f0ac34e534e219a55ad73dcdab295f368ba86ae > > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/statistics/FileSizeLimitIntegrationTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/internal/statistics/StatTypesAreRolledOverRegressionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53108/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Kirk Lund > >