----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53241/#review154071 -----------------------------------------------------------
Ship it! Ship It! - Kevin Duling On Oct. 27, 2016, 2:31 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53241/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 2:31 p.m.) > > > Review request for geode, Kevin Duling and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-1912: make ServerStarter and LocatorStarter as regular rules so that > it's easier to use them in a RuleChain > > * refactor gfshConectionRule as well > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java > 2dffcb713d761ace4b39aa9cf58fdea1d510af0b > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestServersJUnitTest.java > 552a184bb9fd47dc70f1d0ab6022af18aaa7233e > > geode-assembly/src/test/java/org/apache/geode/rest/internal/web/SwaggerVerificationTest.java > 55cc26e28e44bc3be6beeb11e441b55046fcc3a8 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/GfshParser.java > bc25567e12e35e98d74edbd68acda7379503a895 > > geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerMBeanShiroJUnitTest.java > 992c27d5e2216879d66d9b8f1425ec2b5de0eeb1 > > geode-core/src/test/java/org/apache/geode/management/internal/security/CacheServerStartupRule.java > c9ae99700061865874fbcc691a0281f2cbf5075b > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsPostProcessorTest.java > 60f58da8e1d047b9dde772d60eba4ada4428e9af > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshCommandsSecurityTest.java > ce9c21c202d35202fb4b8bdf84fa90b100fa2c47 > > geode-core/src/test/java/org/apache/geode/management/internal/security/GfshShellConnectionRule.java > e7724f75fd23f3530b6b2e3214b6b1bfb2d1cca9 > > geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameTest.java > f754f2e04fe638d6c9b4cc9c31f513f4b47613ea > > geode-core/src/test/java/org/apache/geode/security/AbstractSecureServerDUnitTest.java > b9efe072d4074a5145efa74b5e69338e16f1d35c > > geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java > cbe4a3bb4204fcf0e5482efb4e682bb9633eee04 > > geode-core/src/test/java/org/apache/geode/security/PeerAuthenticatorDUnitTest.java > 84a4dd457274e3cd6cf1e632842ffa73846abad9 > > geode-core/src/test/java/org/apache/geode/security/PeerSecurityWithEmbeddedLocatorDUnitTest.java > 577a7a1d41476be87f35d5abbba68617d5e8db51 > > geode-core/src/test/java/org/apache/geode/security/SecurityClusterConfigDUnitTest.java > a4b25f52faa1c19168bef71f02897daa4675f39d > > geode-core/src/test/java/org/apache/geode/security/SecurityWithoutClusterConfigDUnitTest.java > 87314ed5b87b409f340ec75c3bcbd7fb838db57c > > geode-core/src/test/java/org/apache/geode/security/StartServerAuthorizationTest.java > 3cafdace9fe10a613a4b16989c87dfdf0bf49a99 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > ba78fdcf731ad307753000057b90766d7757705c > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorStarter.java > 216acef2036b7a53930a05acf95ef15bef6b5759 > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarter.java > 22d3c5671a8faa9f3ee7e6f5051e38e0967c6972 > > geode-web/src/test/java/org/apache/geode/management/internal/security/GfshCommandsOverHttpSecurityTest.java > a4162fd9cf6c6e3aaf9215ae108fd9f6d0239180 > > Diff: https://reviews.apache.org/r/53241/diff/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
