-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53395/#review154604
-----------------------------------------------------------


Ship it!




Thanks for doing this Dan! Would love to see a README with instructions on how 
to get the results (for people not familiar with JMH) and integration of the 
results with Jenkins/CI so we have historical data.  Ship-it!

- William Markito


On Nov. 2, 2016, 6:11 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53395/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 6:11 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Adding a new project with a couple of simple benchmarks using jmh, to
> make it easier for developers to write microbenchmarks of geode.
> 
> 
> Diffs
> -----
> 
>   build.gradle 6e82433e81ad832cc753c71873b112b73b81397e 
>   geode-benchmarks/build.gradle PRE-CREATION 
>   
> geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RangeQueryWithIndexBenchmark.java
>  PRE-CREATION 
>   
> geode-benchmarks/src/jmh/java/org/apache/geode/cache/benchmark/RegionOperationBenchmark.java
>  PRE-CREATION 
>   settings.gradle 5aaa17ad69d1f3e4d3c2c8af5b8a5667b3fab7d9 
> 
> Diff: https://reviews.apache.org/r/53395/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Reply via email to