----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154942 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java (line 1779) <https://reviews.apache.org/r/53355/#comment224733> Note that this test hook is now invoked after we have set the new isShutDownAll hook to true. It use to be invoked before "isShutDownAll" was set to true. This broke ShutdownAllPersistentGatewaySenderDUnitTest - Darrel Schneider On Nov. 3, 2016, 3:16 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53355/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 3:16 p.m.) > > > Review request for geode, anilkumar gingade and Scott Jewell. > > > Bugs: GEODE-1971 > https://issues.apache.org/jira/browse/GEODE-1971 > > > Repository: geode > > > Description > ------- > > shutdownAll now syncs on just the class instead of "this". Since it calls > close which also syncs on the class it is best to get this sync done early > and hold it for the entire shutdown. > Some other methods that were syncing on the class no longer do. They had not > reason for doing so. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > ba4f1f410cef89a276634dadecf46ac80d9c3990 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ShutdownAllDUnitTest.java > 1bb06f1ce1d93c801a51c1d8eb4f18ffeaa9f5cc > > Diff: https://reviews.apache.org/r/53355/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
