FYI, I haven't had any time to work on this further and probably won't have time this week. Looks like there's a newer, more active thread on this anyway.
Thanks, Kirk On Thu, Oct 27, 2016 at 6:02 PM, Kenneth Howe <kh...@pivotal.io> wrote: > 1) +1 - How long were you proposing Kirk? I’d suggest something like > 120-130. Regardless of the length chosen we could end up with anomaly > Darrel pointed out with a comment at the end of a long line. In these cases > it’s probably better to put the comment on a separate line. > 2) +1 > 3) +1 > 4) +1 > > > > On Oct 27, 2016, at 3:37 PM, Darrel Schneider <dschnei...@pivotal.io> > wrote: > > > > something I noticed that may have been caused by the reformatting was an > > end of line comment that ended up with one word on every line. A longer > max > > line probably would have prevented this but now that everything has been > > reformatted with a max of 100 I doubt that it would combine comments like > > this back to a single line. > > > > line 1708 of GMSMembershipManager has an end of line comment > > that ends up with a single word on each line like so: > > List<InternalDistributedMember> members = > > (List<InternalDistributedMember>) ex.getMembers(); // We > > > > // need > > > > // to > > > > // return > > > > // this > > > > // list > > > > // of > > > > // failures > > > > > > On Thu, Oct 27, 2016 at 3:27 PM, Udo Kohlmeyer <ukohlme...@pivotal.io> > > wrote: > > > >> 1) 0 > >> 2) +1 > >> 3) +1 > >> 4) 0 > >> > >> > >> On 27/10/16 3:11 pm, Kirk Lund wrote: > >> > >>> I'd like to propose making a few changes to our IntelliJ and Eclipse > >>> formatters as well as the Eclipse importorder (all in etc/): > >>> > >>> 1) increase max line length (100 is way too short) > >>> 2) make (hopefully minor) changes to make the two formatters more > >>> consistent with each other > >>> 3) change Eclipse importorder to follow the google style as closely as > >>> possible > >>> 4) update the import ordering in IntelliJ formatter to match Eclipse > >>> > >>> The goal is to make both formatters produce the exact same results > >>> including ordering of imports while maintaining them to be as close to > the > >>> google style as possible. Right now if you run IntelliJ formatter, the > >>> result will fail the spotlessCheck. We may have to make some small > >>> compromises in our adherence to the google style but I think that's > >>> reasonable in order to get the formatters both working consistently. > >>> > >>> The gradle spotless tasks currently use the Eclipse formatter. One > further > >>> change would be to add the Eclipse importorder file for spotless to > use. > >>> > >>> -Kirk > >>> > >>> > >> >
