----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53442/#review155228 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java (line 3695) <https://reviews.apache.org/r/53442/#comment225075> I see no reason for the !r.hasServerProxy check geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java (line 3704) <https://reviews.apache.org/r/53442/#comment225076> I think lockForTXCacheModification is now dead code - Darrel Schneider On Nov. 3, 2016, 4:08 p.m., Scott Jewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53442/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 4:08 p.m.) > > > Review request for geode, Darrel Schneider and Eric Shu. > > > Bugs: GEODE-1740 > https://issues.apache.org/jira/browse/GEODE-1740 > > > Repository: geode > > > Description > ------- > > GEODE-1740: Correct potential region inconsistencies with concurrent clear > and transaction commit > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java > de05b0d3991254834da94ed97ada9c9247aa69ab > geode-core/src/main/java/org/apache/geode/internal/cache/RegionMap.java > ee8a84e57b5b72cc801cd2474a51dfd0bd3083f3 > geode-core/src/main/java/org/apache/geode/internal/cache/TXState.java > 99a3b83d931dccd0faec482e42cda7ded18a13e7 > > geode-core/src/test/java/org/apache/geode/internal/cache/ClearTXLockingDUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53442/diff/ > > > Testing > ------- > > New unit test ClearTXLockingDUnitTest > > precheckin > > > Thanks, > > Scott Jewell > >
