> On Nov. 8, 2016, 1:10 a.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java, > > lines 3311-3326 > > <https://reviews.apache.org/r/53557/diff/1/?file=1556244#file1556244line3311> > > > > Maybe this is better suited on the PDXInstance. Maybe a method like > > "isTypeOf(Class). Then at least we don't spread the PDX logic everywhere in > > the code.
I had it coded like that but then LocalRegion had to import and interact with PdxInstanceImpl for the first time and I didn't want to do that. Also, since this constraint check is just for Rest objects it didn't make sense to me to further pollute PdxInstanceImpl with knowledge about Rest objects. I would rather have put it in JSonFormatter but that's a public API and this is an internal implementation detail. So, no I don't agree with putting it in PdxInstanceImpl. - Bruce ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155238 ----------------------------------------------------------- On Nov. 7, 2016, 10:13 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53557/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 10:13 p.m.) > > > Review request for geode, Barry Oglesby, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-2080 > https://issues.apache.org/jira/browse/GEODE-2080 > > > Repository: geode > > > Description > ------- > > If you set a value constraint on a cache Region you will be unable to store > objects in the region via the Rest API. This change-set modifies > LocalRegion's constraint check to look for a Rest document and use its type > name in the constraint check > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 3873e6e159ebba4c1a288e9fccde5dbabd2a1140 > geode-core/src/test/java/org/apache/geode/pdx/PdxClientServerDUnitTest.java > 9a9680a7e14ddec91f005fa0f0c6c3da8d033df2 > > Diff: https://reviews.apache.org/r/53557/diff/ > > > Testing > ------- > > new test, precheckin > > > Thanks, > > Bruce Schuchardt > >
