----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53637/#review155523 -----------------------------------------------------------
Ship it! Ship It! - Joey McAllister On Nov. 10, 2016, 12:46 a.m., Karen Miller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53637/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 12:46 a.m.) > > > Review request for geode, Dave Barnes, Darrel Schneider, Joey McAllister, and > Kirk Lund. > > > Repository: geode > > > Description > ------- > > - add/correct the gfsh show metrics command reference > page to include the offheap category for when the member > is specified > - in the list of OffHeapMemoryStats, correct the name of > a statistic: compactions should be defragmentations > > > Diffs > ----- > > geode-docs/reference/statistics/statistics_list.html.md.erb > 02ed6a783eb6ff01c0897c9f25244bb1cef9d33b > geode-docs/tools_modules/gfsh/command-pages/show.html.md.erb > 98009f1cfb413b3d2111944d9d58bbbace625ccf > > Diff: https://reviews.apache.org/r/53637/diff/ > > > Testing > ------- > > gradle rat check passes > > java class that has the names of the OffHeapMemoryStats is > geode-core/src/main/java/org/apache/geode/internal/offheap/OffHeapStorage.java > > > Thanks, > > Karen Miller > >