----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53685/ -----------------------------------------------------------
(Updated Nov. 14, 2016, 8:56 p.m.) Review request for geode, Kevin Duling, Kirk Lund, and Udo Kohlmeyer. Repository: geode Description ------- * add the "disconnect" command when we close the GfshShellConnectionRule so that no heartbeat thread is left to pollute other tests. * Fix the test so that it truely test the jmx ssl connection, and fix the configuration mishaps. * The above fix revealed another bug (GEODE-2099: race condition), ignored the other two tests for now. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/net/SSLConfigurationFactory.java 76fb04169f06f82022858cbd0a03eadac8a42ef6 geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerAdvisee.java 0467c486a0e343bf745fe743172ed4fce750c5b4 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/JmxOperationInvoker.java 456f76bb5592b000c75fe733553219c09d1b5381 geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java b6afcca7cf8a27c2ad90d6ea570755a63ac0e89b geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java 44da08be416240f49cbe9dfb8653f41eaea8777e Diff: https://reviews.apache.org/r/53685/diff/ Testing ------- Thanks, Jinmei Liao
