> On Nov. 16, 2016, 6:06 p.m., Dan Smith wrote: > > What is the JUnit4DistributedTestCase change for?
If a previous test failed with suspect strings in tearDownDistributedTestCase, the postTearDown would not get called for the unit test. This then caused the rest of the tests to fail because any clean up for that specific test was not being done. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53814/#review156087 ----------------------------------------------------------- On Nov. 16, 2016, 5:22 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53814/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 5:22 p.m.) > > > Review request for geode, Barry Oglesby, nabarun nag, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Added new versions of messages, preventing CumulativeNonDistinctResults from > being sent back to a pre Geode client. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommandQuery.java > 08c2ecf > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CommandInitializer.java > 579a3e1 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query.java > a6dc022 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/Query651.java > 51b2a24 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryGeode10.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/QueryWithParametersGeode10.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/internal/JUnit4DistributedTestCase.java > 838bb29 > > Diff: https://reviews.apache.org/r/53814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
