I wrote several tests & fixed a slight bug in the previous patch for Ticket #235
I've attached a new patch [1] to the ticket [2] [1] http://trac.geoext.org/attachment/ticket/235/autoDisableLayerNode.2.patch [2] http://trac.geoext.org/ticket/235/ Matt Priour Kestrel Computer Consulting -------------------------------------------------- From: "Alexandre Dube" <[email protected]> Sent: Tuesday, November 09, 2010 7:24 AM To: "Matt Priour" <[email protected]> Cc: "GeoEXT Dev" <[email protected]> Subject: Re: [Dev] Patch on ticket 235 > Matt, > > Please, let me know when you've got something. I'm willing to give it a > try. > > Thanks a lot for all your efforts, > > Alexandre > > > On 10-11-08 11:19 AM, Matt Priour wrote: >> It probably needs tests. I never have made the time to actually write >> them. >> I was going to set up a map with a few layers and test the following >> conditions: >> 1) OpenLayers.Layer.inRange is correct and affects the layerNode properly >> when it would be changed due one of the following properties: >> a. maxExtent / minExtent >> b. maxScale / minScale >> c. maxResolution / minResolution >> 2) That the node is in the correct enable/disable state added to the tree >> based on the layer's inRange property >> >> Maybe I can simplify this and only test for the correct response to the >> inRange property. I think that would be valid if the inRange property >> changes are already tested for in the OpenLayers test suite. >> >> If a simple test of the node's response to the inRange property on the >> 'moveend' event and at the time of node creation is sufficient, then I >> could defiantly write those tests tonight and update the patch. >> >> Matt Priour >> Kestrel Computer Consulting >> >> -------------------------------------------------- >> From: "Alexandre Dube" <[email protected]> >> Sent: Monday, November 08, 2010 9:50 AM >> To: "GeoEXT Dev" <[email protected]> >> Subject: [Dev] Patch on ticket 235 >> >>> Hi, >>> >>> I'd like to know if the patch [1] attached to the following ticket >>> [2] could be ready for commit. What can I do to help it being pushed >>> forward ? >>> >>> Thanks, >>> >>> Alexandre >>> >>> >>> [1] >>> http://trac.geoext.org/attachment/ticket/235/autoDisableLayerNode.patch >>> [2] http://trac.geoext.org/ticket/235 >>> >>> -- >>> Alexandre Dubé >>> Mapgears >>> www.mapgears.com >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://www.geoext.org/cgi-bin/mailman/listinfo/dev >>> > > > -- > Alexandre Dubé > Mapgears > www.mapgears.com > > _______________________________________________ Dev mailing list [email protected] http://www.geoext.org/cgi-bin/mailman/listinfo/dev
