Re: svn commit: r124464 - /geronimo/trunk/modules/security/src/test/org/apache/geronimo/security/jaas/TimeoutTest.java

[Dain Sundstrom]

Doesn't that disable the entire test case?  I know in this case they  
are the same, but normally when a test is bad it is just one method in  
a test class.

Anyway, I do like the idea of disabling tests in the POM.
-dain
--
Dain Sundstrom
Chief Architect
Gluecode Software
310.536.8355, ext. 26
On Jan 7, 2005, at 8:49 AM, Ralf Barkow wrote:
Hoi Dain,
I feel, X-ing out tests is not a good idea. Please disable tests in  
the relevant maven project.xml file (Build Specification ;  
<excludes>), e.g.

      (...)
   <!-- =================== -->
   <!-- Build Specification -->
   <!-- =================== -->
   <build>
       <unitTest>
           <includes>
               <include>**/*Test.java</include>
           </includes>
           <excludes>
               <exclude>**/Abstract*.java</exclude>
               <exclude>**/LoginKerberosNonGeronimoTest.java</exclude>
               <exclude>**/LoginKerberosTest.java</exclude>
               <exclude>**/TimeoutTest.java</exclude>             
</excludes>
       </unitTest>
   </build>
</project>

Thanks,
--  Ralf

[EMAIL PROTECTED] wrote:
Author: dain
Date: Thu Jan  6 16:04:05 2005
New Revision: 124464
URL: http://svn.apache.org/viewcvs?view=rev&rev=124464
Log:
Disable timeout as it ALWASY fails on osx
Modified:
   
geronimo/trunk/modules/security/src/test/org/apache/geronimo/ 
security/jaas/TimeoutTest.java

Modified:  
geronimo/trunk/modules/security/src/test/org/apache/geronimo/ 
security/jaas/TimeoutTest.java
Url:  
http://svn.apache.org/viewcvs/geronimo/trunk/modules/security/src/ 
test/org/apache/geronimo/security/jaas/TimeoutTest.java? 
view=diff&rev=124464&p1=geronimo/trunk/modules/security/src/test/org/ 
apache/geronimo/security/jaas/TimeoutTest.java&r1=124463&p2=geronimo/ 
trunk/modules/security/src/test/org/apache/geronimo/security/jaas/ 
TimeoutTest.java&r2=124464
====================================================================== 
========
---  
geronimo/trunk/modules/security/src/test/org/apache/geronimo/ 
security/jaas/TimeoutTest.java	(original)
+++  
geronimo/trunk/modules/security/src/test/org/apache/geronimo/ 
security/jaas/TimeoutTest.java	Thu Jan  6 16:04:05 2005
@@ -158,7 +158,10 @@
        kernel.shutdown();
    }
-    public void testTimeout() throws Exception {
+    public void testNothing() {
+    }
+
+    public void XtestTimeout() throws Exception {
        LoginContext context = new LoginContext("properties-client",  
new AbstractTest.UsernamePasswordCallback("alan", "starcraft"));