I agree with your assessment. I am just ramping up with maven, so I can't argue with your suggestion.

I did a build from the activemq directory and, with no surprise, it worked. I had a look at their project.properties and the define the multiproject.includes as:

maven.multiproject.includes=\
modules/*/project.xml,\
transports/*/project.xml,\
stores/*/project.xml,\
itests/*/project.xml

whereas the geronimo project.properties define it as:

maven.multiproject.includes=\
plugins/*/project.xml,\
specs/*/project.xml,\
openejb/modules/*/project.xml,\
applications/*/project.xml,\
modules/*/project.xml,\
activemq/modules/core/project.xml,\
activemq/modules/gbean/project.xml,\
activemq/modules/ra/project.xml,\
activemq/stores/jdbm/project.xml,\
howl/logger/project.xml,\
tranql/*/project.xml

I wonder if geronimo should take the same wildcard approach as activemq and define the includes as (unless we were trying to minimize the amount of files required):

maven.multiproject.includes=\
plugins/*/project.xml,\
specs/*/project.xml,\
openejb/modules/*/project.xml,\
applications/*/project.xml,\
modules/*/project.xml,\
activemq/modules/*/project.xml,\
activemq/transports/*/project.xml,\
activemq/stores/*/project.xml,\
howl/logger/project.xml,\
tranql/*/project.xml

Mark


[EMAIL PROTECTED] wrote:

Mark,

David's suggestion works, but I still think there is a problem that needs to be fixed (patch attached to JIRA issue) so that Geronimo and all associated projects can be built successfully using the instructions on the Wiki.

The file:


geronimo\activemq\modules\gbean\src\java\org\codehaus\activemq\store\jdbc\JDBCPersistenceAdapterGBean.java



requires:


geronimo\activemq\activemq\stores\jdbc\src\java\org\codehaus\activemq\store\jdbc\ JDBCPersistenceAdapterGBean.java

Therefore shouldn't geronimo\project.properties have the following file added to its maven.multiproject.includes property (what my patch does): ?

   activemq/stores/jdbc/project.xml


Can someone explain why David's suggested commands work, but the commands I am using (that the Wiki also has) don't ?


Thanks,

John


Mark <[EMAIL PROTECTED]> wrote on 21/01/2005 06:05:43 PM:



John,

I had this problem last week too. David Blevins posted a message about doing:

------------
maven clean  default
Make sure you are online when doing the build
------------

I ended up doing:

maven clean
maven  -Dmaven.test.skip=true -Dmaven.itest.skip=true default

Mark

John Sisson (JIRA) wrote:



[ http://issues.apache.org/jira/browse/GERONIMO-541?


page=comments#action_57872 ]


John Sisson commented on GERONIMO-541:
--------------------------------------

With the following build commands:

maven m:update
maven m:rebuild -Dmaven.test.skip=true -Dmaven.itest.skip=true

I have been having this compile error for a few days now:

D:


\Projects\J2EE\geronimo\activemq\modules\gbean\src\java\org\codehaus\activemq\store\jdbc\JDBCPersistenceAdapterGBean.


java:97: cann


ot resolve symbol
symbol  : method createTransactionStore ()
location: class org.codehaus.activemq.store.jdbc.JDBCPersistenceAdapter
      return pa.createTransactionStore();
               ^

I have attached a patch that fixes the problem.





Upgrade ActiveMQ to 2.0 and use JDBC as default persistence option
------------------------------------------------------------------

       Key: GERONIMO-541
       URL: http://issues.apache.org/jira/browse/GERONIMO-541
   Project: Apache Geronimo
      Type: Improvement
Components: ActiveMQ
  Versions: 1.0-M3
  Reporter: Hiram Chirino
  Assignee: Hiram Chirino
   Fix For: 1.0-M4













.






Reply via email to