David Jencks wrote:
I discovered and (I think) fixed some errors in the switcher. As a result my enthusiasm for including it in m4 is rather weak. I'm finding fixing things in 2 places somewhat unpleasant.

Let me know...I can help.


Also, WRT the switcher, I think it is usual not to label xml fragments as xml files but call them something like .ent.

Its not really an ENT (XML include)...its a merge file from velocity. Whatever its called is fine with me.

Jeff



thanks
david jencks
On Jul 19, 2005, at 4:43 PM, Jeff Genender wrote:

This is now fixed...but noticed its M5. I thought we agreed to the Jetty/Tomcat switcher in M4. before I update JIRA can we get some resolution on this?

Thanks,

Jeff

Aaron Mulder (JIRA) wrote:

TomcatModuleBuilderTest busted
------------------------------
         Key: GERONIMO-781
         URL: http://issues.apache.org/jira/browse/GERONIMO-781
     Project: Geronimo
        Type: Bug
  Components: Tomcat      Versions: 1.0-M5        Reporter: Aaron Mulder
 Assigned to: Jeff Genender     Priority: Blocker
As a result of the recent changes to the Tomcat GBeans, the TomcatModuleBuilderTest blows up. It creates an entire Tomcat GBean structure by hand, and now sets invalid properties on GBeans (engine on host not hosts on engine) and when I tried to fix it I was stuck on complaints that "localhost is not a legal virtual host" or something to that effect. I've commented out the entire test for now, but if someone who understands the new GBean structure could take a peek that would be great.


--
Jeff Genender
http://geronimo.apache.org

Reply via email to