Switch all references in standard plans to not use <gbean-name>
---------------------------------------------------------------

         Key: GERONIMO-837
         URL: http://issues.apache.org/jira/browse/GERONIMO-837
     Project: Geronimo
        Type: Bug
  Components: general  
    Versions: 1.0-M4    
    Reporter: Aaron Mulder
     Fix For: 1.0


Since (at least in theory) the default domain and server names could be changed 
an so on, it seems like it would be better if all GBean references in the 
default plans use the syntax where they specify a few particular values and let 
the rest default, instead of providing full GBean/Object-Names.

For example, in system-activemq-plan.xml, instead of:

<gbean name="ActiveMQ.jdbc" 
class="org.activemq.store.jdbc.JDBCPersistenceAdapterGBean">
  <reference name="dataSource">
    <gbean-name>
      
geronimo.server:J2EEApplication=null,J2EEServer=geronimo,JCAResource=org/apache/geronimo/SystemDatabase,
      j2eeType=JCAManagedConnectionFactory,name=SystemDatasource
    </gbean-name>
  </reference>
</gbean>

Use:

<gbean name="ActiveMQ.jdbc" 
class="org.activemq.store.jdbc.JDBCPersistenceAdapterGBean">
  <reference name="dataSource">
    <application>null</application>
    <moduleType>JCAResource</moduleType>
    <module>org/apache/geronimo/SystemDatabase</module>
    <type>JCAManagedConnectionFactory</type>
    <name>SystemDatasource</name>
  </reference>
</gbean>

The following plans appear to have <gbean-name> elements (I just grepped):

client-system-plan.xml
deployer-system-plan.xml
interop-server-plan.xml
j2ee-client-plan.xml
j2ee-deployer-plan.xml
j2ee-runtime-deployer-plan.xml
j2ee-server-plan.xml
spring-deployer-plan.xml
system-activemq-plan.xml
system-plan.xml


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to