Sachin Patel wrote:
Could we just prevent that by overriding the maven:eclipse goal in the projects' maven.xml and echo out a message stating a message that no .classpath generation is necessary since these are already eclipse projects?

Lets get others' input on this. If the .classpath inclusion is just for convenience, then I am against this since, again, we are detracting from the way geronimo does things. Throughout geronimo, we let maven build the project ide files. It makes sense due to the many ways these files can get changed due to people's preferences. I really want to have consistency in all of our projects, unless its absolutely necessary. Once we break consistency, we are headed down a slippery slope.


FYI. The mevenide plugin is also including the .classpath in their repo.

They also use cvs, so then should we drop svn and use cvs too? IMHO, this is comparing apples to oranges. Mevenide is not part of a very large application server and is not affected by a much bigger overall build. Also, just because another project does it, does not mean its the best way for this project. Thats a facet of all of open source...each project has their own way of doing things.


Sachin.

Jeff Genender wrote:

Hmmm now that I think about this...

Sachin, these files will likely get overwritten when someone does a "maven eclipse". Be prepared for these to get overwritten fairly often, and will likely get rechecked in.

Jeff

Jeff Genender wrote:



Sachin Patel wrote:

Yes, I think this is needed. Since these are eclipse plugins to begin with I consider these to be part of the project configuration. Eclipse users should be able to directly import these projects into Eclipse without having to generate the .classpath.



As long as these have no machine specific info in it then it may be ok. ..ie same configuration that will work on Windows, Linux, and Mac. But normally, I am against this. We usually use maven to generate these files for us.

Jeff



Jeff Genender wrote:

I noticed these files going into the eclipse plugin:

UU   sandbox/eclipse-plugin/org.apache.geronimo.ui/.classpath
UU sandbox/eclipse-plugin/org.apache.geronimo.deployment.model/.classpath
UU   sandbox/eclipse-plugin/org.apache.geronimo.core/.classpath


Are these ok? IIRC, these are user/computer specific to the user's setup. Are these supposed to be checked in (.classpath)??

Jeff


Reply via email to