I think we should include this as an additional configuration rather
than as part of j2ee-server-plan.xml. It is quite possible that users
will want to use Sun's javamail that they get for themselves, and we
should not require modifying our default plans to make that possible.
Also, I'd like to point out again GERONIMO-1003 which makes gbean
attributes manageable by default. If anyone objects to this please
speak up sooner rather than later. I may have misunderstood your
comment, but right now the properties attribute is manageable. I'm not
sure how much separating out the server name would buy us.
thanks
david jencks
On Sep 11, 2005, at 8:55 PM, Aaron Mulder wrote:
I don't get it. Do we have a working SMTP transport? If so,
let's leave the GBean in, provide a manageable property for the server
name, and let the user configure it. It can default to localhost,
which
will work on many Linux machines. I could certainly add a property
for it
to the installer.
Aaron
On Mon, 12 Sep 2005 [EMAIL PROTECTED] wrote:
Author: jboynes
Date: Sun Sep 11 19:38:27 2005
New Revision: 280240
URL: http://svn.apache.org/viewcvs?rev=280240&view=rev
Log:
remove mail as there is no reasonable default for the server
Modified:
geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
Modified:
geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
URL:
http://svn.apache.org/viewcvs/geronimo/trunk/modules/assembly/src/
plan/j2ee-server-plan.xml?rev=280240&r1=280239&r2=280240&view=diff
======================================================================
========
--- geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml
(original)
+++ geronimo/trunk/modules/assembly/src/plan/j2ee-server-plan.xml Sun
Sep 11 19:38:27 2005
@@ -136,16 +136,6 @@
<uri>geronimo/jars/geronimo-derby-${geronimo_version}.jar</uri>
</dependency>
- <!-- mail -->
- <dependency>
-
<uri>geronimo/jars/geronimo-mail-${geronimo_version}.jar</uri>
- </dependency>
-
- <!-- This little puppy will register a null transport for SMTP
-->
-<!-- <dependency>-->
-<!--
<uri>geronimo-spec/jars/geronimo-null-SMTP-SNAPSHOT.jar</uri>-->
-<!-- </dependency>-->
-
<gbean name="DefaultThreadPool"
class="org.apache.geronimo.pool.ThreadPool">
<attribute name="keepAliveTime">5000</attribute>
<attribute name="poolSize">30</attribute>
@@ -222,13 +212,6 @@
</gbean>
<gbean
gbeanName="geronimo.server:j2eeType=JVM,J2EEServer=geronimo,name=JVM"
class="org.apache.geronimo.j2ee.management.impl.JVMImpl"/>
-
-
- <gbean name="mail/MailSession"
class="org.apache.geronimo.mail.MailGBean">
- <attribute name="properties">
- mail.smtp.host=mail.apache.com
- </attribute>
- </gbean>
<gbean name="eis/JAXR"
class="org.apache.geronimo.webservices.jaxr.JAXRGBean"/>