No problem. I've just tested under Jetty and Tomcat and all is fine (except the NullPointerException under Tomcat which I've logged and about to look into...).
Not too surprising. We'll follow the same code in either case... We'll never look in the client-context if the package name is commons.logging...
--kevan
On 9/30/05, Jeff Genender <[EMAIL PROTECTED]> wrote:
Kevan,
Can you please run one more test for us?
With your patch installed, can you please not include the commons-logging
in your web-inf/lib? I am afraid we will get a ClassNotFoundException.
If it does, then we need to rethink this patch. If it doesn't, then I
will commit the change.
I would test this myself, but I am at work right now without SVN access:(
Thanks,
Jeff
> [ http://issues.apache.org/jira/browse/GERONIMO-518?page=all ]
>
> Kevan Miller updated GERONIMO-518:
> ----------------------------------
>
> Attachment: excludeCommonsLogging.patch
>
> Exclude Commons Logging from the context-priority-classloader. It's
> extremely likely that other "implementation" packages should be added to
> the current exclusion list. This only fixes commons logging...
>
> I've tested under Jetty and all seemed well. My app deploy failed under
> Tomcat, but I believe that's a different problem. I'll open a Jira for
> that...
>
>> Deploying Struts app fails on Logging ClassCastException
>> --------------------------------------------------------
>>
>> Key: GERONIMO-518
>> URL: http://issues.apache.org/jira/browse/GERONIMO-518
>> Project: Geronimo
>> Type: Bug
>> Components: core, web
>> Reporter: Aaron Mulder
>> Assignee: Aaron Mulder
>> Priority: Critical
>> Fix For: 1.0-M5
>> Attachments: excludeCommonsLogging.patch, my-mailreader.war
>>
>> Deploying a web app based on Struts results in the ClassCastException in
>> commons logging displayed below. The web app includes a version of
>> commons-logging in its WEB-INF/lib. The same web app can be
>> successfully deployed in Tomcat 5.0.25 with no problems.
>> Exception in thread "Thread-4" java.lang.ExceptionInInitializerError
>> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>> Method)
>> at
>> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java :39)
>> at
>> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
>> at
>> java.lang.reflect.Constructor.newInstance(Constructor.java :494)
>> at java.lang.Class.newInstance0(Class.java:350)
>> at java.lang.Class.newInstance(Class.java:303)
>> at org.mortbay.jetty.servlet.Holder.newInstance(Holder.java:199)
>> at
>> org.mortbay.jetty.servlet.ServletHolder.start(ServletHolder.java:240)
>> at
>> org.mortbay.jetty.servlet.ServletHandler.initializeServlets(ServletHandler.java:447)
>> at
>> org.mortbay.jetty.servlet.WebApplicationHandler.initializeServlets(WebApplicationHandler.java:298)
>> at
>> org.mortbay.jetty.servlet.WebApplicationContext.doStart (WebApplicationContext.java:512)
>> at
>> org.apache.geronimo.jetty.JettyWebAppContext.doStart(JettyWebAppContext.java:244)
>> ...
>> Caused by: org.apache.commons.logging.LogConfigurationException :
>> java.lang.ClassCastException:
>> org.apache.geronimo.kernel.log.GeronimoLogFactory
>> at
>> org.apache.commons.logging.LogFactory$2.run(LogFactory.java:609)
>> at java.security.AccessController.doPrivileged(Native Method)
>> at
>> org.apache.commons.logging.LogFactory.newFactory(LogFactory.java:561)
>> at
>> org.apache.commons.logging.LogFactory.getFactory (LogFactory.java:298)
>> at
>> org.apache.commons.logging.LogFactory.getLog(LogFactory.java:395)
>> at
>> org.apache.struts.action.ActionServlet.<clinit>(ActionServlet.java :375)
>> ... 67 more
>> Caused by: java.lang.ClassCastException:
>> org.apache.geronimo.kernel.log.GeronimoLogFactory
>> at
>> org.apache.commons.logging.LogFactory$2.run (LogFactory.java:571)
>> ... 72 more
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
