[ http://issues.apache.org/jira/browse/GERONIMO-1455?page=all ]
David Jencks updated GERONIMO-1455:
-----------------------------------
Assign To: Dain Sundstrom
This is caused by confusing the functions of PersistentConfigurationList and
ManageableAttributeStore in the LocalAttributeStore:
Index:
modules/system/src/test/org/apache/geronimo/system/configuration/LocalAttributeManagerTest.java
===================================================================
---
modules/system/src/test/org/apache/geronimo/system/configuration/LocalAttributeManagerTest.java
(revision 369113)
+++
modules/system/src/test/org/apache/geronimo/system/configuration/LocalAttributeManagerTest.java
(working copy)
@@ -71,8 +71,9 @@
localAttributeManager.removeConfiguration(configurationName.toString());
// should not load
- newDatas = new
HashSet(localAttributeManager.setAttributes(configurationName, originalDatas,
getClass().getClassLoader()));
- assertEquals(0, newDatas.size());
+// The next lines mix the "load" question with the "what attributes are
overridden" question. Please answer them separately.
+// newDatas = new
HashSet(localAttributeManager.setAttributes(configurationName, originalDatas,
getClass().getClassLoader()));
+// assertEquals(0, newDatas.size());
}
public void testGBeanShouldLoad() throws Exception {
Index:
modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
===================================================================
---
modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
(revision 369113)
+++
modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
(working copy)
@@ -104,9 +104,11 @@
if (configuration == null) {
return gbeanDatas;
}
- if (!configuration.isLoad()) {
- return Collections.EMPTY_LIST;
- }
+// IMO (DJ) the following lines mix the config.list and config.xml
functionalities for no reason.
+// They also cause GERONIMO-1455
+// if (!configuration.isLoad()) {
+// return Collections.EMPTY_LIST;
+// }
// index the incoming datas
Map datasByName = new HashMap();
I've committed this fix to head:
Sending
modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Sending
modules/system/src/test/org/apache/geronimo/system/configuration/LocalAttributeManagerTest.java
Transmitting file data ..
Committed revision 369397.
Dain, do you have any problems with this? Do you want to add something to the
test to replace the broken part? If not assign it to me (djencks) and I will
clean it up and apply to 1.0.1
> Start of CAR does not load and start its GBeans
> -----------------------------------------------
>
> Key: GERONIMO-1455
> URL: http://issues.apache.org/jira/browse/GERONIMO-1455
> Project: Geronimo
> Type: Bug
> Components: kernel
> Versions: 1.0
> Environment: AG 1.0 on WinXP with Sun 1.4.2_08
> Reporter: Donald Woods
> Assignee: Dain Sundstrom
> Priority: Critical
> Fix For: 1.1, 1.0.1
>
> Start AG 1.0 with Log4j logging set to Debug.
> Login in to Console.
> Open System Modules portlet.
> Select Start for geronimo/j2ee-corba/1.0/car. It shows it as started in the
> Console and the state as Running in the logfile, but there is no output from
> CSSBean, SunORB or OpenEJB since the Server and UnprotectedServer GBeans were
> not actually started.
> Shutdown server.
> Start Server.
> The geronimo/j2ee-corba/1.0/car is started and port 1050 is now active.
> In the geronimo.log, there are now CSSBean, SunORB and OpenEJB log
> statements, since the Server and UnprotectedServer GBeans were loaded and
> started.
> The same problem occurs with the command-line deployer. Using the start
> param, the CAR is loaded, but none of the GBeans are loaded or started until
> you stop and restart the server.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
