[ http://issues.apache.org/jira/browse/GERONIMO-1523?page=all ]
     
David Jencks resolved GERONIMO-1523:
------------------------------------

    Resolution: Fixed

This fix for simplicity gets the HandleDelegate from the CorbaGBean.  I think 
it is fairly reasonable to tie the implementation of the HandleDelegate to the 
particular orb we use in this way.  However if anyone objects it is easy to 
provide a separate gbean for the handle delegate, but it would increase the 
complexity of the deployers slightly.

Head:
Sending        
modules/connector-builder/src/test/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EJBReferenceBuilder.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/RefContext.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/UnavailableEJBReferenceBuilder.java
Sending        
modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/EJBRefContextTest.java
Sending        
modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/MockEJBConfigBuilder.java
Sending        
modules/jetty-builder/src/test/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
Sending        
modules/naming/src/java/org/apache/geronimo/naming/java/ComponentContextBuilder.java
Adding         
modules/naming/src/java/org/apache/geronimo/naming/reference/HandleDelegateReference.java
Sending        
modules/naming-builder/src/java/org/apache/geronimo/naming/deployment/ENCConfigBuilder.java
Sending        
modules/naming-builder/src/test/org/apache/geronimo/naming/deployment/MessageDestinationTest.java
Sending        
modules/tomcat-builder/src/test/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilderTest.java
Transmitting file data ............
Committed revision 371145.     

Openejb:
Checking in modules/core/src/java/org/openejb/corba/CORBABean.java;
new revision: 1.19; previous revision: 1.18
Checking in modules/core/src/java/org/openejb/corba/CORBAHandleDelegate.java;
new revision: 1.4; previous revision: 1.3
Checking in 
modules/openejb-builder/src/java/org/openejb/deployment/OpenEJBReferenceBuilder.java;
new revision: 1.4; previous revision: 1.3    

branch lw_assemblies:
Sending        
modules/connector-builder/src/test/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/EJBReferenceBuilder.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/RefContext.java
Sending        
modules/j2ee-builder/src/java/org/apache/geronimo/j2ee/deployment/UnavailableEJBReferenceBuilder.java
Sending        
modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/EJBRefContextTest.java
Sending        
modules/j2ee-builder/src/test/org/apache/geronimo/j2ee/deployment/MockEJBConfigBuilder.java
Sending        
modules/jetty-builder/src/test/org/apache/geronimo/jetty/deployment/JettyModuleBuilderTest.java
Sending        
modules/naming/src/java/org/apache/geronimo/naming/java/ComponentContextBuilder.java
Adding         
modules/naming/src/java/org/apache/geronimo/naming/reference/HandleDelegateReference.java
Sending        
modules/naming-builder/src/java/org/apache/geronimo/naming/deployment/ENCConfigBuilder.java
Sending        
modules/naming-builder/src/test/org/apache/geronimo/naming/deployment/MessageDestinationTest.java
Sending        
modules/tomcat-builder/src/test/org/apache/geronimo/tomcat/deployment/TomcatModuleBuilderTest.java
Transmitting file data ...........
Committed revision 371148.  

> Openejb corba class is included (serialized) in all enc contexts
> ----------------------------------------------------------------
>
>          Key: GERONIMO-1523
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1523
>      Project: Geronimo
>         Type: Bug
>     Versions: 1.1
>     Reporter: David Jencks
>     Assignee: David Jencks
>      Fix For: 1.1

>
> If you build a configuration for a j2ee module while the openejb deployer 
> config is loaded, the enc context will include a serialized 
> CORBAHandleDelegate$HandleDelegateReferece.  Then the enc won't deserialize 
> unless the openejb-core jar is in the classpath.  This sorta impedes smaller 
> servers.
> I'm going to instead use the "look it up from a gbean" trick we use the the 
> orb and resources so all that gets serialized is a geronimo naming reference 
> class and an object name.  This will modify at least methods/fields 
> EarContext, EarConfigBuilder, AppClientModuleBuilder, and 
> OpenEJBReferenceBuilder, EJBReferenceBuilder, and RefContext.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to