[
http://issues.apache.org/jira/browse/GERONIMO-1593?page=comments#action_12365340
]
Bruce Snyder commented on GERONIMO-1593:
----------------------------------------
The javamail-transport patch is failing:
$ patch -p0 < ./GERONIMO-1593-javamail-transport.patch
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/authentication/CramMD5Authenticator.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/authentication/LoginAuthenticator.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/authentication/ClientAuthenticator.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/authentication/PlainAuthenticator.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPReply.java
Hunk #1 succeeded at 23 with fuzz 1.
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransportException.java
Hunk #1 FAILED at 17.
1 out of 2 hunks FAILED -- saving rejects to file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransportException.java.rej
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java
Hunk #2 succeeded at 74 with fuzz 1.
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPSendFailedException.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPSTransport.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/MalformedSMTPReplyException.java
Hunk #1 FAILED at 17.
1 out of 2 hunks FAILED -- saving rejects to file
src/java/org/apache/geronimo/javamail/transport/smtp/MalformedSMTPReplyException.java.rej
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPMessage.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPAddressFailedException.java
(Stripping trailing CRs from patch.)
patching file
src/java/org/apache/geronimo/javamail/transport/smtp/SMTPAddressSucceededException.java
(Stripping trailing CRs from patch.)
patching file src/resources/META-INF/javamail.default.providers
Hunk #1 succeeded at 7 with fuzz 1.
Also, the build after applying this patch fails looking for some classes in the
mail module (e.g., org.apache.geronimo.mail.util.Base64,
org.apache.geronimo.mail.util.Hex and org.apache.geronimo.mail.util.XText):
java:compile:
<depend closure="false" srcdir="1.4" dump="false"
destdir="/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/target/classes"></depend>
[echo] Compiling to
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/target/classes
[javac] Compiling 31 source files to
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/target/classes
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/CramMD5Authenticator.java:26:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Base64;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/CramMD5Authenticator.java:27:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Hex;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:29:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Base64;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:30:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Hex;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/LoginAuthenticator.java:24:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Base64;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/PlainAuthenticator.java:24:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Base64;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:53:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.Base64;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:54:
package org.apache.geronimo.mail.util does not exist
[javac] import org.apache.geronimo.mail.util.XText;
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/CramMD5Authenticator.java:99:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.CramMD5Authenticator
[javac] String responseString = username + " " + new
String(Hex.encode(digest));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:168:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] String responseString = clientResponse + new
String(Hex.encode(digest.digest()));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:172:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] String validationText = new
String(Hex.encode(digest.digest()));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:228:
cannot resolve symbol
[javac] symbol : variable Base64
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] String cnonce = new String(Base64.encode(cnonceBytes));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:247:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] clientResponse = new
String(Hex.encode(digest.digest())) + ":" + nonce + ":00000001:" + cnonce +
":auth:";
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:255:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] String responseString = clientResponse + new
String(Hex.encode(digest.digest()));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/authentication/DigestMD5Authenticator.java:260:
cannot resolve symbol
[javac] symbol : variable Hex
[javac] location: class
org.apache.geronimo.javamail.authentication.DigestMD5Authenticator
[javac] String challengeResponse = new
String(Hex.encode(digest.digest()));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:1460:
cannot resolve symbol
[javac] symbol : variable XText
[javac] location: class
org.apache.geronimo.javamail.transport.smtp.SMTPTransport
[javac] command.append(new
String(XText.encode(submitter.getBytes("US-ASCII"))));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:1998:
cannot resolve symbol
[javac] symbol : variable Base64
[javac] location: class
org.apache.geronimo.javamail.transport.smtp.SMTPTransport
[javac] command.append(new
String(Base64.encode(authenticator.evaluateChallenge(null))));
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:2035:
cannot resolve symbol
[javac] symbol : variable Base64
[javac] location: class
org.apache.geronimo.javamail.transport.smtp.SMTPTransport
[javac] byte[] challenge =
Base64.decode(line.getMessage().getBytes());
[javac] ^
[javac]
/Users/bsnyder/src/geronimo/trunk/modules/javamail-transport/src/java/org/apache/geronimo/javamail/transport/smtp/SMTPTransport.java:2038:
cannot resolve symbol
[javac] symbol : variable Base64
[javac] location: class
org.apache.geronimo.javamail.transport.smtp.SMTPTransport
[javac] sendLine(new
String(Base64.encode(authenticator.evaluateChallenge(challenge))));
[javac] ^
[javac] 19 errors
BUILD FAILED
File...... /Users/bsnyder/.maven/cache/maven-java-plugin-1.5/plugin.jelly
Element... ant:javac
Line...... 63
Column.... -1
Compile failed; see the compiler error output for details.
Total time : 18 seconds
Finished at : Monday, February 6, 2006 1:14:57 PM MST
I don't see any of these classes in the mail module. Did you forgot a patch to
that module perhaps? There is a Base64 and a Hex class in the util module
(org/apache/geronimo/util/encoders/Base64,
org/apache/geronimo/util/encoders/Hex), but I don't see an XText class
anywhere.
Because of these issues, I have not yet committed anything from this second
patch.
> Add SMTP Authentication and STARTTLS support.
> ---------------------------------------------
>
> Key: GERONIMO-1593
> URL: http://issues.apache.org/jira/browse/GERONIMO-1593
> Project: Geronimo
> Type: New Feature
> Components: mail
> Versions: 1.1
> Reporter: Rick McGuire
> Attachments: GERONIMO-1593-geronimo-spec-javamail.patch,
> GERONIMO-1593-javamail-transport.patch
>
> These patches add SMTP PLAIN, LOGIN, CRAM-MD5, and DIGEST_MD5 authentication
> to the SMTP driver. Also adds an "smtps" protocl driver and STARTTLS
> support.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
