[ 
http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12367045
 ] 

Jeff Genender commented on GERONIMO-1035:
-----------------------------------------

Thanks.  The management patch works, but now your Tomcat cat patch will not 
compile.  There seems to be some missing classes here as well also.

<depend closure="false" srcdir="1.4" dump="false" 
destdir="/Users/powerbook/Projects/geronimo/modules/tomcat/target/classes"></depend>
    [echo] Compiling to 
/Users/powerbook/Projects/geronimo/modules/tomcat/target/classes
    [javac] Compiling 46 source files to 
/Users/powerbook/Projects/geronimo/modules/tomcat/target/classes
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:31:
 cannot find symbol
    [javac] symbol  : class WebConnectorStatsImpl
    [javac] location: package org.apache.geronimo.management.stats
    [javac] import org.apache.geronimo.management.stats.WebConnectorStatsImpl;
    [javac]                                             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:43:
 cannot find symbol
    [javac] symbol  : class WebConnectorStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
    [javac]     private WebConnectorStatsImpl stats = new 
WebConnectorStatsImpl();
    [javac]             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:64:
 cannot find symbol
    [javac] symbol  : class WebConnectorStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
    [javac]     private void getStats(WebConnectorStatsImpl stats, String 
port){ 
    [javac]                           ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:40:
 cannot find symbol
    [javac] symbol  : class WebServletStatsImpl
    [javac] location: package org.apache.geronimo.management.stats
    [javac] import org.apache.geronimo.management.stats.WebServletStatsImpl;
    [javac]                                             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:66:
 cannot find symbol
    [javac] symbol  : class WebServletStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.TomcatServletHolder
    [javac]     private WebServletStatsImpl stats = new WebServletStatsImpl();
    [javac]             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatWebAppContext.java:49:
 cannot find symbol
    [javac] symbol  : class WebModuleStatsImpl
    [javac] location: package org.apache.geronimo.management.stats
    [javac] import org.apache.geronimo.management.stats.WebModuleStatsImpl;
    [javac]                                             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:33:
 cannot find symbol
    [javac] symbol  : class WebModuleStatsImpl
    [javac] location: package org.apache.geronimo.management.stats
    [javac] import org.apache.geronimo.management.stats.WebModuleStatsImpl;
    [javac]                                             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:45:
 cannot find symbol
    [javac] symbol  : class WebModuleStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
    [javac]     private WebModuleStatsImpl stats = new WebModuleStatsImpl();
    [javac]             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:81:
 cannot find symbol
    [javac] symbol  : class WebModuleStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
    [javac]     private void getStats(WebModuleStatsImpl stats, long 
processingTime, long startupTime, 
    [javac]                           ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:81:
 getStats(java.lang.String,long,long,long) is already defined in 
org.apache.geronimo.tomcat.stats.ModuleStats
    [javac]     private void getStats(WebModuleStatsImpl stats, long 
processingTime, long startupTime, 
    [javac]                  ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ConnectorStats.java:43:
 cannot find symbol
    [javac] symbol  : class WebConnectorStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ConnectorStats
    [javac]     private WebConnectorStatsImpl stats = new 
WebConnectorStatsImpl();
    [javac]                                               ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/TomcatServletHolder.java:66:
 cannot find symbol
    [javac] symbol  : class WebServletStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.TomcatServletHolder
    [javac]     private WebServletStatsImpl stats = new WebServletStatsImpl();
    [javac]                                             ^
    [javac] 
/Users/powerbook/Projects/geronimo/modules/tomcat/src/java/org/apache/geronimo/tomcat/stats/ModuleStats.java:45:
 cannot find symbol
    [javac] symbol  : class WebModuleStatsImpl
    [javac] location: class org.apache.geronimo.tomcat.stats.ModuleStats
    [javac]     private WebModuleStatsImpl stats = new WebModuleStatsImpl();
    [javac]                                            ^
    [javac] Note: * uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 13 errors


> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
>          Key: GERONIMO-1035
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1035
>      Project: Geronimo
>         Type: New Feature
>   Components: Tomcat
>     Versions: 1.0-M5
>  Environment: All
>     Reporter: Anita Kulshreshtha
>     Assignee: Jeff Genender
>      Fix For: 1.1
>  Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, 
> management.patch, stats.zip, tomcat-builder.patch, tomcat-builder.patch, 
> tomcat-builder.patch, tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment 
> descriptor individually. This is needed by JSR-77 and for gathering tomcat 
> internal statistics.   

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to