[ http://issues.apache.org/jira/browse/GERONIMO-1659?page=comments#action_12370078 ]
Jacek Laskowski commented on GERONIMO-1659: ------------------------------------------- Anita, may it be that you're doing the tests offline and your copy of maven-surefire-plugin is outdated? Could you double-check if it's not the case. You're making very good points about tests in M1 vs M2. I once had to revert a patch when I had found out it broke M1 build. There's no other way to make sure everything works than doing the build in M1 and M2 before committing a change. I'm trying to not forget about it. The changes to ServerInfo are to introduce a concept of GERONIMO_BASE and GERONIMO_HOME so that Geronimo can share most of its jars and (that's what I'm not sure) the config-store. I remember Gianny and John have been working on it and it might be that the tests don't cover it enough. Write some additional tests if you like and I'll commit them, too. The more tests the better. You may also want to use maven-clover-plugin to see how detailed the tests are. Don't forget to update yout maven-surefire-plugin. Mine is 2.1.3-20060228.012944-10. > Module migration to Maven 2: system > ----------------------------------- > > Key: GERONIMO-1659 > URL: http://issues.apache.org/jira/browse/GERONIMO-1659 > Project: Geronimo > Type: Sub-task > Reporter: Anders Hessellund Jensen > Assignee: Jacek Laskowski > Attachments: maven-timestamp-plugin.zip, > org.apache.geronimo.system.serverinfo.ServerInfoTest.txt, pom.patch, > system-m2-migration-new.patch, system-m2-migration.patch > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
