[ 
http://issues.apache.org/jira/browse/GERONIMO-1761?page=comments#action_12371512
 ] 

John Sisson commented on GERONIMO-1761:
---------------------------------------

I agree we should be giving credit.  AFAIK, the standard way is to use the 
NOTICE.txt file.

The geronimo-util module doesn't contain any crypto implementations, it is just 
an abstraction layer for crypto implementations.  I don't think crypto is a 
good name for it considering the other stuff it contains such as:

* An encoders package (e.g. Base64) that are used by the remoteDeployUtil and 
the KeyStoreGBean.

* An ASN.1 package that is used by the KeyStoreGBean and AFAIK, OpenEJB uses 
some classes in some corba support (X509 names). 

John

> Change geronimo-util module to geronimo-crypto, give credit where credit is 
> due
> -------------------------------------------------------------------------------
>
>          Key: GERONIMO-1761
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1761
>      Project: Geronimo
>         Type: Bug
>   Components: core
>     Versions: 1.0
>     Reporter: Aaron Mulder
>      Fix For: 1.2

>
> The util module holds a bunch of crypto-related stuff.  Speculation is that 
> it's the non-encumbered code from bouncycastle.  It should be in a more 
> accurately named module and package, since it's not just generic "util" code. 
>  It would also be nice to put a note in every file header saying where it's 
> from, or at least in NOTICE.txt perhaps.  There may be improvements we want 
> to track?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to