Please test again since Dain committed the patch yesterday. In my testing, this did allow "undeploy myapp". If it doesn't work for you, can you give specific steps to reproduce the problem using the welcome sample application (applications/welcome/target/*.war and if needed, configs/welcome-jetty/target/plan/plan.xml).
Thanks, Aaron On 5/9/06, anita kulshreshtha <[EMAIL PROTECTED]> wrote:
This refers to - http://issues.apache.org/jira/browse/GERONIMO-1945 and http://issues.apache.org/jira/browse/GERONIMO-1971 If a webapp with named "myapp" is deployed, It gets deployed as default/myapp/..../war. it is not possible to undeploy it with - java -jar bin\deployer.jar undeploy myapp It must be undeployed using : java -jar bin\deployer.jar undeploy default/myapp/explicit-version/war Here are my observations - 1. o.a.g.k.Repository.Artifact.create(id) does not allow id of the form "myapp" and throws exception. 2. A method almostMatch(Artifact a) (or a better name..) is needed that will match default/myapp//.. with default/myapp/explicit-version/war. This will allow us to undeploy using just "myapp". This will also solve the problem with the hot-deployment in G-1947. 3. o.a.g.deployment.plugin.ConfigIdExtractor.identifyTargetModuleIDs(..) needs to call exactMatch in the 'second pass' so that default/myapp/explicit-version/war is returned in the list. Is this the correct approach? Thanks Anita __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
