On 7/2/06, Jason Dillon (JIRA) <[email protected]> wrote:

> [RTC] Remove Geronimo modules from dependencyManagement in root pom.xml
> -----------------------------------------------------------------------
>
>          Key: GERONIMO-2161
>          URL: http://issues.apache.org/jira/browse/GERONIMO-2161
>      Project: Geronimo
>         Type: Task
>     Security: public(Regular issues)
>   Components: buildsystem
>     Reporter: Jason Dillon
>     Assignee: Jason Dillon
>      Fix For: 1.2
>  Attachments: GERONIMO-2161-v1.patch

I've got questions about the patch. Appreciate comments.

1/ Why has the version tag been added? Doesn't M2 take care of it?

        <dependency>
            <groupId>org.apache.geronimo.modules</groupId>
            <artifactId>geronimo-security-builder</artifactId>
+            <version>${pom.version}</version>
        </dependency>

2/ Could the syntax of application names be changed to

<name>Geronimo Applications :: The Magic G Ball :: WAR</name>

rather than

<name>Geronimo Applications, The Magic G Ball :: WAR</name>

to be aligned with

<name>Geronimo Applications :: The Magic G Ball</name>

3/ Why has this been excluded?

+++ modules/directory/pom.xml   (working copy)
...
+            <exclusions>
+                <exclusion>
+                    <groupId>commons-test</groupId>
+                    <artifactId>commons-test</artifactId>
+                </exclusion>
+            </exclusions>


Jacek

--
Jacek Laskowski
http://www.laskowski.net.pl

Reply via email to