Hi Bill, No. I applied the patch against an existing copy of the trunk tree and local repo. Let me apply this against the latest tree (the one that has Jason's big patch). I'll also clean out the local repo. I'll let you know shortly.
Cheers Prasad On 7/7/06, Bill Dudney <[EMAIL PROTECTED]> wrote:
Hi Prasad, Perhaps I'm missing another patch or something? The top level pom (geronimo/pom.xml) sets the src directory to 'src/java'. The deployment plugin has its src in the standard m2 place of 'src/main/java'. Thus nothing gets compiled. I reset the src directory to 'src/main/java' and I get many compile errors. I applied the patch (and only that patch) to a fresh clean check out of geronimo Rev 419886 (head of trunk). I must be missing something if you are able to get a clean compile. TTFN, Bill Dudney MyFaces - http://myfaces.apache.org Cayenne - http://incubator.apache.org/projects/cayenne.html On Jul 6, 2006, at 8:04 PM, Prasad Kashyap wrote: Oh I forgot to mention. Check the *.log files in the top level module and individual modules. If I remember right, you can run the mvn site:site command to generate an HTML page of the results. Cheers Prasad On 7/6/06, Bill Dudney <[EMAIL PROTECTED]> wrote: Hi Prasad, Thanks, - I guess I was hoping that it was something smaller :-) I had to; 1) install the jetty version but changed version to 1.1 and updated itests/pom.xml to reflect 1.1. instead of 1.1-SNAPSHOT 2) install the tomcat version but changed version to 1.1 and updated itests/pom.xml to reflect 1.1. instead of 1.1-SNAPSHOT 3) enable the utils 3) delete the explicit mention of version from the maven-site-plugin in teardown-tests.pom.xml 4) add junit as a dependency otherwise the mvn failed unless -Dmaven.test.skip=true was specified 5) run mvn Although the build succeeds, nothing appears to happen (see attached log) From what I can tell the geronimo-deployment-plugin is not being built correctly, none of the src's are being compiled and placed into the jar file. I poked around but the reason escapes me... TTFN, Bill Dudney MyFaces - http://myfaces.apache.org Cayenne - http://incubator.apache.org/projects/cayenne.html [INFO] Scanning for projects... [INFO] Reactor build order: [INFO] Geronimo Integration Tests [INFO] Geronimo :: itests :: system [INFO] Geronimo :: itests :: webcontainer [INFO] Geronimo :: itests :: teardown [INFO] ---------------------------------------------------------------------------- [INFO] Building Geronimo Integration Tests [INFO] task-segment: [install] [INFO] ---------------------------------------------------------------------------- [INFO] [site:attach-descriptor] [INFO] [dependency:unpack {execution: unpack}] [INFO] Configured Artifact: org.apache.geronimo.distributions:geronimo-jetty-j2ee:null:1.1:zip [INFO] geronimo-jetty-j2ee-1.1.zip already unpacked. Downloading: http://cvs.apache.org/maven-snapshot-repository/org/apache/geronimo/distributions/geronimo-tomcat-j2ee/1.1/geronimo-tomcat-j2ee-1.1.pom [WARNING] Unable to get resource from repository Maven snapshots (http://cvs.apache.org/maven-snapshot-repository) Downloading: http://repo1.maven.org/maven2/org/apache/geronimo/distributions/geronimo-tomcat-j2ee/1.1/geronimo-tomcat-j2ee-1.1.pom [WARNING] Unable to get resource from repository central (http://repo1.maven.org/maven2) Downloading: http://cvs.apache.org/maven-snapshot-repository/org/apache/geronimo/distributions/geronimo-jetty-j2ee/1.1/geronimo-jetty-j2ee-1.1.pom [WARNING] Unable to get resource from repository Maven snapshots (http://cvs.apache.org/maven-snapshot-repository) Downloading: http://repo1.maven.org/maven2/org/apache/geronimo/distributions/geronimo-jetty-j2ee/1.1/geronimo-jetty-j2ee-1.1.pom [WARNING] Unable to get resource from repository central (http://repo1.maven.org/maven2) [INFO] [antrun:run {execution: prepare}] [INFO] Executing tasks [delete] Deleting 1 files from /private/tmp/foo/sandbox/itests/target/logs [touch] Creating /private/tmp/foo/sandbox/itests/target/logs/results.log [INFO] Executed tasks [INFO] [install:install] [INFO] Installing /private/tmp/foo/sandbox/itests/pom.xml to /Users/bdudney/.m2/repository/org/apache/geronimo/itests/geronimo-itests-parent/1.0/geronimo-itests-parent-1.0.pom [INFO] ---------------------------------------------------------------------------- [INFO] Building Geronimo :: itests :: system [INFO] task-segment: [install] [INFO] ---------------------------------------------------------------------------- [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] [INFO] Nothing to compile - all classes are up to date [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] [INFO] Nothing to compile - all classes are up to date [INFO] [surefire:test] [INFO] No tests to run. [INFO] [jar:jar] [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /private/tmp/foo/sandbox/itests/system-tests/target/system-tests-1.0.jar [INFO] [antrun:run {execution: prepare}] [INFO] Executing tasks [delete] Deleting 1 files from /private/tmp/foo/sandbox/itests/system-tests/target/logs [touch] Creating /private/tmp/foo/sandbox/itests/system-tests/target/logs/results.log [INFO] Executed tasks [INFO] [install:install] [INFO] Installing /private/tmp/foo/sandbox/itests/system-tests/target/system-tests-1.0.jar to /Users/bdudney/.m2/repository/org/apache/geronimo/itests/system-tests/1.0/system-tests-1.0.jar [INFO] ---------------------------------------------------------------------------- [INFO] Building Geronimo :: itests :: webcontainer [INFO] task-segment: [install] [INFO] ---------------------------------------------------------------------------- [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] [INFO] Nothing to compile - all classes are up to date [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] [INFO] Nothing to compile - all classes are up to date [INFO] [surefire:test] [INFO] Surefire report directory: /private/tmp/foo/sandbox/itests/webcontainer-tests/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- There are no tests to run. Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 [INFO] [jar:jar] [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /private/tmp/foo/sandbox/itests/webcontainer-tests/target/webcontainer-tests-1.0.jar [INFO] [antrun:run {execution: prepare}] [INFO] Executing tasks [delete] Deleting 1 files from /private/tmp/foo/sandbox/itests/webcontainer-tests/target/logs [touch] Creating /private/tmp/foo/sandbox/itests/webcontainer-tests/target/logs/results.log [INFO] Executed tasks [INFO] [install:install] [INFO] Installing /private/tmp/foo/sandbox/itests/webcontainer-tests/target/webcontainer-tests-1.0.jar to /Users/bdudney/.m2/repository/org/apache/geronimo/itests/webcontainer-tests/1.0/webcontainer-tests-1.0.jar [INFO] ---------------------------------------------------------------------------- [INFO] Building Geronimo :: itests :: teardown [INFO] task-segment: [install] [INFO] ---------------------------------------------------------------------------- [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] [INFO] Nothing to compile - all classes are up to date [INFO] [resources:testResources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:testCompile] [INFO] Nothing to compile - all classes are up to date [INFO] [surefire:test] [INFO] No tests to run. [INFO] [jar:jar] [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /private/tmp/foo/sandbox/itests/teardown-tests/target/teardown-tests-1.0.jar [INFO] [antrun:run {execution: prepare}] [INFO] Executing tasks [delete] Deleting 1 files from /private/tmp/foo/sandbox/itests/teardown-tests/target/logs [touch] Creating /private/tmp/foo/sandbox/itests/teardown-tests/target/logs/results.log [INFO] Executed tasks [INFO] [antrun:run {execution: prepare}] [INFO] Executing tasks [delete] Deleting 1 files from /private/tmp/foo/sandbox/itests/teardown-tests/target/logs [touch] Creating /private/tmp/foo/sandbox/itests/teardown-tests/target/logs/results.log [INFO] Executed tasks [INFO] [install:install] [INFO] Installing /private/tmp/foo/sandbox/itests/teardown-tests/target/teardown-tests-1.0.jar to /Users/bdudney/.m2/repository/org/apache/geronimo/itests/teardown-tests/1.0/teardown-tests-1.0.jar [INFO] [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] ------------------------------------------------------------------------ [INFO] Geronimo Integration Tests ............................ SUCCESS [12.429s] [INFO] Geronimo :: itests :: system .......................... SUCCESS [1.315s] [INFO] Geronimo :: itests :: webcontainer .................... SUCCESS [0.419s] [INFO] Geronimo :: itests :: teardown ........................ SUCCESS [0.184s] [INFO] ------------------------------------------------------------------------ [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESSFUL [INFO] ------------------------------------------------------------------------ [INFO] Total time: 14 seconds [INFO] Finished at: Thu Jul 06 14:40:10 MDT 2006 [INFO] Final Memory: 8M/14M [INFO] ------------------------------------------------------------------------ On Jul 6, 2006, at 2:02 PM, Prasad Kashyap wrote: Yep. This is it. So what you could do is take a m1 binary and run the mvn install:install-file command to install it into your m2 local repo. The exact syntax of that command is in the error message that you have pasted. Cheers Prasad On 7/6/06, Bill Dudney <[EMAIL PROTECTED]> wrote: Hi Prasad, Is this error that causes you to manually install an m1 built bit into the m2 repo? If so could you point me to exactly what bits to copy? Thanks! -bd- [INFO] Configured Artifact: org.apache.geronimo.distributions:geronimo-jetty-j2ee:null:1.1- SNAPSHOT:zip [INFO] ------------------------------------------------------------------------ [ERROR] BUILD ERROR [INFO] ------------------------------------------------------------------------ [INFO] Failed to resolve artifact. GroupId: org.apache.geronimo.distributions ArtifactId: geronimo-jetty-j2ee Version: 1.1-SNAPSHOT Reason: Unable to download the artifact from any repository Try downloading the file manually from the project website. Then, install it using the command: mvn install:install-file - DgroupId=org.apache.geronimo.distributions -DartifactId=geronimo- jetty-j2ee \ -Dversion=1.1-SNAPSHOT -Dpackaging=zip -Dfile=/path/to/file org.apache.geronimo.distributions:geronimo-jetty-j2ee:zip:1.1- SNAPSHOT from the specified remote repositories: central (http://repo1.maven.org/maven2), Maven snapshots (http://cvs.apache.org/maven-snapshot-repository) [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4 seconds [INFO] Finished at: Thu Jul 06 12:32:17 MDT 2006 [INFO] Final Memory: 5M/9M [INFO] ------------------------------------------------------------------------ On Jul 6, 2006, at 8:35 AM, Prasad Kashyap wrote: > Hi Bill, > > Inline- > > On 7/6/06, Bill Dudney <[EMAIL PROTECTED]> wrote: >> Hi Prasad, >> >> > >> > First we needed the geronimo-deployment-plugin to be in m2. So in >> > http://issues.apache.org/jira/browse/GERONIMO-1738, I got the >> > deployment-plugin migarted to m2. The RTC for this is pending 2 >> more >> > votes. Now, if you and Jason can review and approve it, we can >> get it >> > in the build. >> > >> >> I applied the patch but it appears that there is a problem with it, >> AppTest.java has 3 copies of the code in it for example (as well as >> pom.xml and many if not all the other files). >> >> Here is the url to what I downloaded and I'm looking at; >> http://issues.apache.org/jira/secure/attachment/12324416/geronimo- >> deployment-plugin.patch >> >> which is the first patch from JIRA #1738 referenced above. > > You might want to pick up the latest patch from the "Manage > Attachments" link. The patches on the JIRA page are sorted > alphabetically. The patch that you downloaded was my initial > submission. The other one with ( > http://issues.apache.org/jira/secure/attachment/12335875/geronimo- > deployment-plugin-RTC-VOTE.2.patch > ) is what you need. This was uploaded by David Jencks after reviewing > mine and making some changes based on other reviews. > >> > I used to take an m1 binary distribution and manually put it >> into an >> > m2 local repo for this work. Now that we are working on m2, >> hopefully >> > we shall soon have the binary distributions for us to work with >> > directly. >> > >> >> An m1 distribution of G or something else? >> > > Yes, of G. > > > Cheers > Prasad
