[ http://issues.apache.org/jira/browse/GERONIMO-2097?page=all ]
Alan Cabrera updated GERONIMO-2097:
-----------------------------------
Fix Version/s: 1.1.x
(was: 1.1.1)
Moving unassigned issues over to the 1.1.x pool where they can be worked on for
the, in all probability, 1.1.2 patch.
> PluginRepositoryExporter.updateMavenMetadata(..) may leave maven-metadata.xml
> file open
> ---------------------------------------------------------------------------------------
>
> Key: GERONIMO-2097
> URL: http://issues.apache.org/jira/browse/GERONIMO-2097
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: core, Plugins
> Affects Versions: 1.1
> Reporter: John Sisson
> Priority: Trivial
> Fix For: 1.1.x
>
>
> The code contains the following statement, where the mavenFile variable is a
> File.
> xform.transform(new DOMSource(doc), new StreamResult(mavenFile));
> We have experienced in another issue ( GERONIMO-2095 ) that this does not
> close the FileOutputStream that gets created automatically on your behalf.
> It is safer to create your own FileOutputStream and pass it on the
> StreamResult constructor and ensure it is closed in a finally block. See fix
> for GERONIMO-2095 for an example.
> Since this is in a standalone tool, it probably isn't a high priority as the
> file will be closed when the JVM terminates, but this may not always be used
> as a standalone tool.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
