[ http://issues.apache.org/jira/browse/GERONIMO-2332?page=comments#action_12429452 ] David Jencks commented on GERONIMO-2332: ----------------------------------------
Theres a fairly serious problem with this proposal in that it involves generating source code that does not then have the required apache headers and checking it into svn. Is there a way to use m2 to change the headers on all the files? I don't think john's "minor point" about the possibility of getting an empty jar is relevant since whoever is setting this up will check the generated files into svn so that no one else has to run the generate source profile (at least until sun updates the schemas and we decide to use updated versions). As this points out another problem is that we have no record of how we got the generated classes: sun has fixed problems in the schemas in the past without changing anything that we can identify from the generated code. As a result of these factors I'm -0.99 on this proposal at the moment. > RTC Put the generated xmlbeans files for the j2ee 1.4 schemas in svn in a > spec module so we don't need the schemas in svn at all > -------------------------------------------------------------------------------------------------------------------------------- > > Key: GERONIMO-2332 > URL: http://issues.apache.org/jira/browse/GERONIMO-2332 > Project: Geronimo > Issue Type: RTC > Security Level: public(Regular issues) > Components: specs > Affects Versions: 1.2, 1.1.1, 1.1.2 > Reporter: David Jencks > Assigned To: David Jencks > Fix For: 1.2, 1.1.1, 1.1.2 > > Attachments: GERONIMO-2332-1.1.patch, > GERONIMO-2332-openejb-2.1.patch, GERONIMO-2332-trunk.patch, > geronimo-schema_1.4_spec-generated-src.zip, geronimo-schema_1.4_spec-src.zip > > > See GERONIMO-2307. It seems that the option with the least legal exposure is > to not distribute and sun schema files and not have any in our svn. This is > a proposed spec module that uses a m2 profile to pull the schemas from suns > website (where they are freely available), run xmlbeans on them, and remove > the copies of the schemas that xmlbeasn helpfully tries to include in the > output. We can then check this stuff into svn. > A normal non-profile build then just builds these sources into a jar. We can > replace the xmlbeans step in j2ee-schema with a geronimo dependency on this > new spec jar. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
